Stop setting remediationAction at the root policy level

This allows the policy generator to have granular control of the
remediation action of configuration policies it may automatically
generator on behalf of the user (i.e. Kyverno policy reporting).

Signed-off-by: mprahl <[email protected]>

Author: mprahl

docs/policygenerator-reference.yaml

@@ -36,8 +36,8 @@ policyDefaults:
     # file. If given, this placement rule will be used by all policies by default. (See
     # clusterSelectors to generate a new Placement instead.)
     placementRulePath: ""
-  # Optional. The remediation action ("inform" or "enforce") for the policy. This defaults to
-  # "inform".
+  # Optional. The remediation action ("inform" or "enforce") for each configuration policy. This
+  # defaults to "inform".
   remediationAction: "inform"
   # Optional. The severity of the policy violation. This defaults to "low".
   severity: "low"

internal/plugin.go

@@ -306,9 +306,8 @@ func (p *Plugin) createPolicy(policyConf *types.PolicyConfig) error {
 			"namespace": p.PolicyDefaults.Namespace,
 		},
 		"spec": map[string]interface{}{
-			"disabled":          policyConf.Disabled,
-			"policy-templates":  []map[string]map[string]interface{}{*policyTemplate},
-			"remediationAction": policyConf.RemediationAction,
+			"disabled":         policyConf.Disabled,
+			"policy-templates": []map[string]map[string]interface{}{*policyTemplate},
 		},
 	}
 

internal/plugin_test.go

@@ -80,7 +80,6 @@ spec:
                             name: my-configmap
                 remediationAction: inform
                 severity: low
-    remediationAction: inform
 ---
 apiVersion: policy.open-cluster-management.io/v1
 kind: Policy
@@ -111,7 +110,6 @@ spec:
                             name: my-configmap
                 remediationAction: inform
                 severity: low
-    remediationAction: inform
 ---
 apiVersion: apps.open-cluster-management.io/v1
 kind: PlacementRule
@@ -206,7 +204,6 @@ spec:
                             name: my-configmap
                 remediationAction: inform
                 severity: low
-    remediationAction: inform
 ---
 apiVersion: policy.open-cluster-management.io/v1
 kind: Policy
@@ -237,7 +234,6 @@ spec:
                             name: my-configmap
                 remediationAction: inform
                 severity: low
-    remediationAction: inform
 ---
 apiVersion: apps.open-cluster-management.io/v1
 kind: PlacementRule
@@ -391,7 +387,6 @@ spec:
                             name: my-configmap
                 remediationAction: inform
                 severity: low
-    remediationAction: inform
 `
 	expected = strings.TrimPrefix(expected, "\n")
 	assertEqual(t, output, expected)
@@ -460,7 +455,6 @@ spec:
                             name: my-configmap
                 remediationAction: inform
                 severity: low
-    remediationAction: inform
 `
 	expected = strings.TrimPrefix(expected, "\n")
 	assertEqual(t, output, expected)