Skip to content

Component build version is always called rc version even though it is not an RC #670

@Skarlso

Description

@Skarlso

Context

The Makefile under component/Makefile is always calling print-rc-version which results in naming the component rc1 always. Even though it's just a simple release.

The logic needs to be updated like it is in release.yaml:

    - name: Set release version
      run: |
        if ${{ inputs.release_candidate }}; then
          echo "RELEASE_VERSION=$(go run $GITHUB_WORKSPACE/pkg/version/generate/release_generate.go print-rc-version)" >> $GITHUB_ENV
        else
          echo "RELEASE_VERSION=$(go run $GITHUB_WORKSPACE/pkg/version/generate/release_generate.go print-version)" >> $GITHUB_ENV
        fi

instead of using $(CANDIDATE) which is no longer a supported functionality.

Version
v0.26.1

To Reproduce
Steps to reproduce the behavior:

Actual behavior
A clear and concise description of what is happening.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots (optional)
If applicable, add screenshots to help explain your problem.

Environment

  • windows
  • linux
  • mac

Additional Comments
Any observation, gut feeling or other information you think help the community to troubleshoot the problem?

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/tasksmall task, normally part of feature or epic

    Type

    Projects

    Status

    🆕 ToDo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions