feat(condo): DOMA-11513 add "id" in SuggestServiceProviderOutput, clarify that output is not nullable (#6114)

* feat(condo): DOMA-11513 add "id" and "type" in SuggestServiceProviderOutput, clarify that output is not nullable

* fix(condo): DOMA-11513 change return type for tests

Author: YEgorLu

apps/condo/domains/resident/schema/SuggestServiceProviderService.js

@@ -59,14 +59,14 @@ const SuggestServiceProviderService = new GQLCustomSchema('SuggestServiceProvide
         },
         {
             access: true,
-            type: 'type SuggestServiceProviderOutput { tin: String!, name: String! }',
+            type: 'type SuggestServiceProviderOutput { id: String!, tin: String!, name: String!, type: String! }',
         },
     ],
 
     queries: [
         {
             access: access.canSuggestServiceProvider,
-            schema: 'suggestServiceProvider (data: SuggestServiceProviderInput!): [SuggestServiceProviderOutput]',
+            schema: 'suggestServiceProvider (data: SuggestServiceProviderInput!): [SuggestServiceProviderOutput!]',
             resolver: async (parent, args, context = {}) => {
                 if (context.authedItem.type === RESIDENT) {
                     await checkLimits(context.authedItem.id, context)
@@ -91,7 +91,7 @@ const SuggestServiceProviderService = new GQLCustomSchema('SuggestServiceProvide
 
                 const serviceProvidersForSuggest = await filterOrganizationsByAcquiringContextOrMeterResourceOwnership(context, serviceProviders)
                 return uniqBy(serviceProvidersForSuggest, 'tin')
-                    .map(serviceProvider => pick(serviceProvider, ['tin', 'name']))
+                    .map(serviceProvider => pick(serviceProvider, ['id', 'tin', 'name', 'type']))
             },
         },
     ],

apps/condo/schema.graphql

@@ -83914,8 +83914,10 @@ input SuggestServiceProviderInput {
 }
 
 type SuggestServiceProviderOutput {
+  id: String!
   tin: String!
   name: String!
+  type: String!
 }
 
 input FindUnitsByAddressInput {
@@ -88823,7 +88825,7 @@ type Query {
   predictTicketClassification(data: PredictTicketClassificationInput!): TicketClassifier
   getResidentExistenceByPhoneAndAddress(data: GetResidentExistenceByPhoneAndAddressInput!): GetResidentExistenceByPhoneAndAddressOutput
   findOrganizationsByAddress(data: FindOrganizationsByAddressInput!): [FindOrganizationByAddressOutput]
-  suggestServiceProvider(data: SuggestServiceProviderInput!): [SuggestServiceProviderOutput]
+  suggestServiceProvider(data: SuggestServiceProviderInput!): [SuggestServiceProviderOutput!]
   findUnitsByAddress(data: FindUnitsByAddressInput!): FindUnitsByAddressOutput
 
   """

apps/condo/schema.ts

@@ -71280,7 +71280,7 @@ export type Query = {
    * }`
    */
   predictTransactionClassification?: Maybe<PredictTransactionClassificationOutput>;
-  suggestServiceProvider?: Maybe<Array<Maybe<SuggestServiceProviderOutput>>>;
+  suggestServiceProvider?: Maybe<Array<SuggestServiceProviderOutput>>;
   ticketAnalyticsReport?: Maybe<TicketAnalyticsReportOutput>;
   ticketReportWidgetData?: Maybe<TicketReportWidgetOutput>;
 };
@@ -91790,8 +91790,10 @@ export type SuggestServiceProviderInput = {
 
 export type SuggestServiceProviderOutput = {
   __typename?: 'SuggestServiceProviderOutput';
+  id: Scalars['String']['output'];
   name: Scalars['String']['output'];
   tin: Scalars['String']['output'];
+  type: Scalars['String']['output'];
 };
 
 export type SyncRemoteClientInput = {