Skip to content

Commit 8d49f2e

Browse files
feat: display library title in browser tab (openedx#1305)
1 parent f3274e7 commit 8d49f2e

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

src/library-authoring/LibraryAuthoringPage.test.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1+
import { getConfig } from '@edx/frontend-platform';
12
import fetchMock from 'fetch-mock-jest';
3+
import { Helmet } from 'react-helmet';
24
import {
35
fireEvent,
46
initializeMocks,
@@ -122,6 +124,10 @@ describe('<LibraryAuthoringPage />', () => {
122124
expect(await screen.findByText('Content library')).toBeInTheDocument();
123125
expect((await screen.findAllByText(libraryTitle))[0]).toBeInTheDocument();
124126

127+
const browserTabTitle = Helmet.peek().title.join('');
128+
const siteName = getConfig().SITE_NAME;
129+
expect(browserTabTitle).toEqual(`${libraryTitle} | ${siteName}`);
130+
125131
expect(screen.queryByText('You have not added any content to this library yet.')).not.toBeInTheDocument();
126132

127133
// "Recently Modified" header + sort shown

src/library-authoring/LibraryAuthoringPage.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React, { useContext, useEffect } from 'react';
2+
import { Helmet } from 'react-helmet';
23
import classNames from 'classnames';
34
import { StudioFooter } from '@edx/frontend-component-footer';
45
import { useIntl } from '@edx/frontend-platform/i18n';
@@ -156,6 +157,7 @@ const LibraryAuthoringPage = () => {
156157
return (
157158
<div className="d-flex">
158159
<div className="flex-grow-1">
160+
<Helmet><title>{libraryData.title} | {process.env.SITE_NAME}</title></Helmet>
159161
<Header
160162
number={libraryData.slug}
161163
title={libraryData.title}

0 commit comments

Comments
 (0)