Skip to content

Commit 2213d45

Browse files
ghassanmasarbrandes
authored andcommitted
fix: sync LMS_BASE_URL for bookmark API if changed
This change makes it possible to use the latest LMS_BASE_API if it was changed because of dynamic config API, which is the default case of tutor. This changes closes openedx/wg-build-test-release/issues/270 Fixes that are simlar to this - gradebook openedx/frontend-app-gradebook/pull/290 - course authoring openedx/frontend-app-authoring/pull/389
1 parent 757d967 commit 2213d45

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/courseware/course/bookmark/BookmarkButton.test.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import React from 'react';
22
import MockAdapter from 'axios-mock-adapter';
33
import { getAuthenticatedHttpClient } from '@edx/frontend-platform/auth';
4-
import { getConfig } from '@edx/frontend-platform';
54
import { Factory } from 'rosie';
65
import {
76
render, screen, fireEvent, initializeTestStore, waitFor, authenticatedUser, logUnhandledRequests,
87
} from '../../../setupTest';
98
import { BookmarkButton } from './index';
9+
import { getBookmarksBaseUrl } from './data/api';
1010

1111
describe('Bookmark Button', () => {
1212
let axiosMock;
@@ -32,7 +32,8 @@ describe('Bookmark Button', () => {
3232
mockData.unitId = nonBookmarkedUnitBlock.id;
3333

3434
axiosMock = new MockAdapter(getAuthenticatedHttpClient());
35-
const bookmarkUrl = `${getConfig().LMS_BASE_URL}/api/bookmarks/v1/bookmarks/`;
35+
const bookmarkUrl = getBookmarksBaseUrl();
36+
3637
axiosMock.onPost(bookmarkUrl).reply(200, { });
3738

3839
const bookmarkDeleteUrlRegExp = new RegExp(`${bookmarkUrl}*,*`);
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import { getConfig } from '@edx/frontend-platform';
22
import { getAuthenticatedHttpClient, getAuthenticatedUser } from '@edx/frontend-platform/auth';
33

4-
const bookmarksBaseUrl = `${getConfig().LMS_BASE_URL}/api/bookmarks/v1/bookmarks/`;
4+
export const getBookmarksBaseUrl = () => `${getConfig().LMS_BASE_URL}/api/bookmarks/v1/bookmarks/`;
55

66
export async function createBookmark(usageId) {
7-
return getAuthenticatedHttpClient().post(bookmarksBaseUrl, { usage_id: usageId });
7+
return getAuthenticatedHttpClient().post(getBookmarksBaseUrl(), { usage_id: usageId });
88
}
99

1010
export async function deleteBookmark(usageId) {
1111
const { username } = getAuthenticatedUser();
12-
return getAuthenticatedHttpClient().delete(`${bookmarksBaseUrl}${username},${usageId}/`);
12+
return getAuthenticatedHttpClient().delete(`${getBookmarksBaseUrl()}${username},${usageId}/`);
1313
}

0 commit comments

Comments
 (0)