Skip to content

Conversation

@kaustavb12
Copy link
Member

@kaustavb12 kaustavb12 commented Oct 25, 2025

Description

The PR:

  1. Cherry-picks eshe specific customizations on to sumac.3 from eSHE's sumac.2 branch. More details below.
  2. Backports a bug fix from upstream.

Here's a list of code drifts and their status:

Commit Cherry Picked Comments
chore: remove client's oauth credentials from public repo Not required anymore. Configs moved to android-app-config
chore: bump github upload-artifact action to v4 Not required anymore. Upstream fixed it via PR#401
fixup! fix: downloaded videos were not working due to gating API needing online access
fix: downloaded videos were not working due to gating API needing online access
fix: Make SSO login use JWT for better compatibility Upstreamed - PR#371
feat: "Go To Prerequisite Section" button and previews
feat: add "Gated" UI state for subsections
feat: add flag to remove registration from app (#9) Upstreamed - PR#387
fix: making imageUrl independent of API_HOST_URL formatting Not required anymore. Upstream fixed it via PR#346
fix: Support pull to refresh for empty dashboard Upstreamed - PR#375
chore: configure for app to connect to dev instance Not required anymore. Configs moved to android-app-config
feat: Adding the course number and course effort on the course cards UI Layout changed. Need to speak to eSHE about reimplementing this
fix: Fixing config file to correctly parse the API_HOST_URL Not required anymore. Configs moved to android-app-config
feat: Support for login and registration via a browser custom tab Upstreamed - PR#371
feat: hide some options for the MVP

Other information

Private Ref : BB-9799
Companion PR : android-app-config#6

@kaustavb12 kaustavb12 force-pushed the kaustav/cherry_pick_eshe_customization_sumac3 branch from 014acd6 to 5c8059c Compare October 25, 2025 16:51
navinkarkera and others added 3 commits October 25, 2025 23:54
* feat: hide some menu options

* chore: update dev config

(cherry picked from commit 9303505)
(cherry picked from commit c6bc3ad)
(cherry picked from commit 881b73b)
(cherry picked from commit 02bc3da)
(cherry picked from commit 43e5679)
(cherry picked from commit 442c393)
@kaustavb12 kaustavb12 force-pushed the kaustav/cherry_pick_eshe_customization_sumac3 branch from 5c8059c to 416c322 Compare October 25, 2025 18:25
…ine access

(cherry picked from commit f4ecc5e)
(cherry picked from commit 9befe5f)
…ing online access

(cherry picked from commit 8f17fff)
(cherry picked from commit 885c26f)
@kaustavb12 kaustavb12 force-pushed the kaustav/cherry_pick_eshe_customization_sumac3 branch from 416c322 to 8453b5b Compare October 25, 2025 18:40
@kaustavb12 kaustavb12 force-pushed the kaustav/cherry_pick_eshe_customization_sumac3 branch from 8453b5b to 4b5871a Compare October 26, 2025 03:14
@viadanna
Copy link
Member

Approved 👍

  • I tested this on my Android device.
  • I read through the code.

@kaustavb12 kaustavb12 merged commit d168daf into eshe-mvp-release/sumac.3 Oct 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants