Pass DataStore Upsert Original pSQL Error Messages#188
Merged
JVickery-TBS merged 10 commits intocanada-v2.10from Feb 10, 2025
Merged
Pass DataStore Upsert Original pSQL Error Messages#188JVickery-TBS merged 10 commits intocanada-v2.10from
JVickery-TBS merged 10 commits intocanada-v2.10from
Conversation
- Include the original psql error message and code in the upsert errors.
- Added change log file.
- Continued FK maps in datastore_info.
wardi
reviewed
Jan 31, 2025
Member
wardi
left a comment
wardi
left a comment
There was a problem hiding this comment.
instead of maintaining this patch on our fork can we parse the FK errors here and return them in a way that would be useful for all API users? That kind of a change could go upstream eventually
Author
|
@wardi like the REGEX parsing that I have done in Recombinant? Move it into the ckanext-datastore postgres.py ?? |
- Finalized foreign constraint info for datastore_info.
Author
|
@wardi I threw the Foreign Key info for datastore_info into this one too if your able to review that here as well?? |
- Query for constraint usage.
wardi
reviewed
Jan 31, 2025
wardi
reviewed
Jan 31, 2025
wardi
reviewed
Jan 31, 2025
wardi
reviewed
Jan 31, 2025
wardi
reviewed
Jan 31, 2025
wardi
reviewed
Jan 31, 2025
- Parse psql errors for foreign constraints. - Use psql literal strings for ds info fks.
Author
|
@wardi okay! should be handling the foreign constraint errors in here now. Will parse them and give an error message along with a dict of the parsed values (ref keys, ref values, ref table name). |
- Return list of strings.
wardi
reviewed
Feb 7, 2025
wardi
reviewed
Feb 7, 2025
Co-authored-by: Ian Ward <ian@excess.org>
- Fake gettext for babel extractions.
- Added comments for the parial string formatter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(logic): ds upsert info;
This will allow Recombinant to parse the FK constraint error messages, without showing the pSQL error to the user still.