feat(dev): comments;

- TODO disable redirects for logged in users.

Author: JVickery-TBS

ckanext/language_domains/config_declaration.yaml

@@ -19,6 +19,17 @@ groups:
         description: |
           Secret key for JWT encoding.
         required: true
+      - key: ckanext.language_domains.redirect_user_sessions
+        example: true
+        default: false
+        description: >
+          Controls whether or not domains will be redirected for
+          logged in users. E.g. if logged in on the English domain,
+          you will not be redirected to the French domain - and vice versa.
+          This helps with sticky sessions when not using the
+          ckanext.language_domains.enable_jwt_login option.
+        required: false
+        validators: ignore_missing boolean_validator
       - key: ckanext.language_domains.enable_jwt_login
         example: true
         default: false

ckanext/language_domains/plugin.py

@@ -72,6 +72,10 @@ def __init__(self, app: Any, config: 'CKANConfig'):
         self.default_domain = uri_parts.netloc
         self.domain_scheme = uri_parts.scheme
         self.root_paths = config.get('ckanext.language_domains.root_paths')
+        self.redirect_user_sessions = config.get(
+            'ckanext.language_domains.redirect_user_sessions', False)
+        self.enable_jwt_login = config.get(
+            'ckanext.language_domains.enable_jwt_login', False)
 
     def __call__(self, environ: Any, start_response: Any) -> Any:
         extra_response_headers = []
@@ -114,6 +118,7 @@ def __call__(self, environ: Any, start_response: Any) -> Any:
         def _start_response(status: str,
                             response_headers: List[Tuple[str, str]],
                             exc_info: Optional[Any] = None):
+            # TODO: check if there is a user and don't do domain redirects??
             return start_response(
                 # browser requires non 200 response for Location header
                 status if not extra_response_headers else '301',