Add efibootmgr and unify EFI boot entry handling

- Added efibootmgr to grub2-mkconfig package list
- Enhanced boot entry creation for both attended and Kickstart-based installs
- Updated boot label to Edge MicrovisorToolkit
- Improved EFI entry cleanup logic for existing boot entries

Signed-off-by: kinatli jayanth <jayanthx.kintali@intel.com>

Author: Jkintalix

toolkit/imageconfigs/packagelists/grub2-mkconfig.json

@@ -1,6 +1,7 @@
 {
     "packages": [
-        "grub2"
+        "grub2",
+        "efibootmgr"
     ],
     "_comment": "grub2-mkconfig is packaged with the grub2 base package. Images that boot for the first time using the mkconfig flow must therefore have grub2 installed by the tools."
 }

toolkit/tools/liveinstaller/liveinstaller.go

@@ -164,14 +164,27 @@ func runBootEntryCreationCommand(installDetails installationDetails) (err error)
 	const squashErrors = false
 	program := "efibootmgr"
 	cfg := installDetails.finalConfig
+
+	if cfg.DefaultSystemConfig.IsKickStartBoot {
+		logger.Log.Info("Unattended installation: parsing Kickstart file to get disk info")
+
+		kickstartPartitionFile := "/tmp/part-include"
+		disks, _, err := configuration.ParseKickStartPartitionScheme(kickstartPartitionFile)
+		logger.PanicOnError(err, "Failed to parse partition schema")
+		// Save disk config settings
+		if len(disks) == 0 {
+			return fmt.Errorf("Kickstart parsed disk list is empty")
+		}
+		cfg.Disks = disks
+	}
 	bootPartIdx, bootPart := cfg.GetBootPartition()
 	bootDisk := cfg.GetDiskContainingPartition(bootPart)
 	commandArgs := []string{
 		"-c",                            // Create a new bootnum and place it in the beginning of the boot order
 		"-d", bootDisk.TargetDisk.Value, // Specify which disk the boot file is on
 		"-p", fmt.Sprintf("%d", bootPartIdx+1), // Specify which partition the boot file is on
-		"-l", "'\\EFI\\BOOT\\bootx64.efi'", // Specify the path for where the boot file is located on the partition
-		"-L", "Azure Linux", // Specify what label you would like to give this boot entry
+		"-l", "\\EFI\\BOOT\\bootx64.efi", // Specify the path for where the boot file is located on the partition
+		"-L", "Edge Microvisor Toolkit", // Specify what label you would like to give this boot entry
 		"-v", // Be verbose
 	}
 	err = shell.ExecuteLive(squashErrors, program, commandArgs...)
@@ -180,15 +193,27 @@ func runBootEntryCreationCommand(installDetails installationDetails) (err error)
 
 func removeOldAzureLinuxBootTargets() (err error) {
 	const squashErrors = false
-	logger.Log.Info("Removing pre-existing 'Azure Linux' boot targets from efibootmgr")
-	program := "efibootmgr" // Default behavior when piped or called without options is to print current boot order in a human-readable format
-	commandArgs := []string{
-		"|", "grep", "\"Azure Linux\"", // Filter boot order for Azure Linux boot targets
-		"|", "sed", "'s/* Azure Linux//g'", // Pruning for just the bootnum
-		"|", "sed", "'s/Boot*//g'", // Pruning for just the bootnum
-		"|", "xargs", "-t", "-i", "efibootmgr", "-b", "{}", "-B", // Calling efibootmgr --delete-bootnum (aka `-B`) on each pre-existing bootnum with an Azure Linux label
+	logger.Log.Info("Removing pre-existing 'Edge Microvisor Toolkit' boot targets from efibootmgr")
+
+	// First, test if Edge Microvisor Toolkit entries exist
+	testCmd := `efibootmgr | grep "Edge Microvisor Toolkit"`
+
+	// Actual deletion command
+	deleteCmd := `efibootmgr | grep "Edge Microvisor Toolkit" | awk '{print $1}' | sed 's/Boot//g' | sed 's/\*//g' | xargs -t -I {} efibootmgr -b {} -B`
+
+	// Run test command to check for matches
+	logger.Log.Infof("deletion test command: %s", testCmd)
+	err = shell.ExecuteLive(squashErrors, "sh", "-c", testCmd)
+
+	if err != nil {
+		// No Edge Microvisor Toolkit entries found
+		logger.Log.Info("No 'Edge Microvisor Toolkit' boot entries found. Nothing to delete.")
+		return nil
 	}
-	err = shell.ExecuteLive(squashErrors, program, commandArgs...)
+
+	// Edge Microvisor Toolkit entries found and hence deleting the entries
+	logger.Log.Infof("deletion execution command: %s", deleteCmd)
+	err = shell.ExecuteLive(squashErrors, "sh", "-c", deleteCmd)
 	return
 }