Remove 'background' label from labels page (#1057)

Author: camiloHimura

web_ui/src/core/labels/utils.test.ts

@@ -14,9 +14,11 @@ import {
     getNonEmptyLabelsFromProject,
     getNotEmptyLabelsFromOneTask,
     isAnomalous,
+    isEmptyOrBackgroundLabel,
     isExclusive,
     isGlobal,
     isLocal,
+    isNonEmptyOrBackgroundLabel,
 } from './utils';
 
 it.each([
@@ -263,3 +265,47 @@ describe('filter out exclusive labels', () => {
         expect(filterOutExclusiveLabel(labels)).toHaveLength(0);
     });
 });
+
+describe('isEmptyOrBackgroundLabel', () => {
+    it('returns true for a label that is empty', () => {
+        const label = { isEmpty: true, behaviour: LABEL_BEHAVIOUR.LOCAL };
+        expect(isEmptyOrBackgroundLabel(label)).toBe(true);
+    });
+
+    it('returns true for a label that is background', () => {
+        const label = { isEmpty: false, behaviour: LABEL_BEHAVIOUR.BACKGROUND };
+        expect(isEmptyOrBackgroundLabel(label)).toBe(true);
+    });
+
+    it('returns true for a label that is both empty and background', () => {
+        const label = { isEmpty: true, behaviour: LABEL_BEHAVIOUR.BACKGROUND };
+        expect(isEmptyOrBackgroundLabel(label)).toBe(true);
+    });
+
+    it('returns false for a label that is neither empty nor background', () => {
+        const label = { isEmpty: false, behaviour: LABEL_BEHAVIOUR.LOCAL };
+        expect(isEmptyOrBackgroundLabel(label)).toBe(false);
+    });
+});
+
+describe('isNonEmptyOrBackgroundLabel', () => {
+    it('returns false for a label that is empty', () => {
+        const label = { isEmpty: true, behaviour: LABEL_BEHAVIOUR.LOCAL };
+        expect(isNonEmptyOrBackgroundLabel(label)).toBe(false);
+    });
+
+    it('returns false for a label that is background', () => {
+        const label = { isEmpty: false, behaviour: LABEL_BEHAVIOUR.BACKGROUND };
+        expect(isNonEmptyOrBackgroundLabel(label)).toBe(false);
+    });
+
+    it('returns false for a label that is both empty and background', () => {
+        const label = { isEmpty: true, behaviour: LABEL_BEHAVIOUR.BACKGROUND };
+        expect(isNonEmptyOrBackgroundLabel(label)).toBe(false);
+    });
+
+    it('returns true for a label that is neither empty nor background', () => {
+        const label = { isEmpty: false, behaviour: LABEL_BEHAVIOUR.LOCAL };
+        expect(isNonEmptyOrBackgroundLabel(label)).toBe(true);
+    });
+});

web_ui/src/core/labels/utils.ts

@@ -80,6 +80,7 @@ export const isBackgroundLabel = <T extends EmptyOrBackground>(label: T): boolea
 export const isNonBackgroundLabel = negate(isBackgroundLabel);
 
 export const isEmptyOrBackgroundLabel = overSome([isEmptyLabel, isBackgroundLabel]);
+export const isNonEmptyOrBackgroundLabel = negate(isEmptyOrBackgroundLabel);
 
 export const filterOutEmptyLabel = (labels: readonly Label[]): readonly Label[] => labels.filter(isNonEmptyLabel);
 
@@ -200,3 +201,7 @@ export const getNonEmptyLabelsFromProject = (tasks: Task[]): Label[] => {
 export const getNotEmptyLabelsFromOneTask = (task: Task): readonly Label[] => {
     return filterOutEmptyLabel(task.labels);
 };
+
+export const filterNonEmptyOrBackgroundLabels = (task: Task) => {
+    return task.labels.filter((label) => isNonEmptyOrBackgroundLabel(label));
+};

web_ui/src/pages/project-details/components/project-labels/utils.ts

@@ -8,7 +8,7 @@ import {
     LabelTreeLabelProps,
 } from '../../../../core/labels/label-tree-view.interface';
 import { Label, LabelsRelationType } from '../../../../core/labels/label.interface';
-import { getNotEmptyLabelsFromOneTask } from '../../../../core/labels/utils';
+import { filterNonEmptyOrBackgroundLabels } from '../../../../core/labels/utils';
 import { DOMAIN } from '../../../../core/projects/core.interface';
 import { Task, TaskMetadata } from '../../../../core/projects/task.interface';
 import { isNotCropTask } from '../../../../shared/utils';
@@ -64,7 +64,7 @@ export const getTasksMetadata = (tasks: Task[], keepNoObjectLabels = false): Tas
     const filteredTasks = tasks.filter(isNotCropTask);
 
     return filteredTasks.map((task, index) => {
-        const taskLabels = keepNoObjectLabels ? task.labels : [...getNotEmptyLabelsFromOneTask(task)];
+        const taskLabels = keepNoObjectLabels ? task.labels : filterNonEmptyOrBackgroundLabels(task);
         const parent = !!index ? filteredTasks[index - 1].labels[0] : undefined;
         const parentId = parent ? parent.id : null;
         const parentGroup = parent ? parent.group : null;