Skip to content

Commit 55c458d

Browse files
authored
Fix invalid assertion in user management e2e tests (#1463)
1 parent c02b17e commit 55c458d

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

web_ui/tests/e2e/daily/members-management.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ test.describe('Members management suite', () => {
121121
...organizationAdminMember,
122122
firstName: 'Updated',
123123
lastName: 'Old Admin',
124-
role: USER_ROLE.ORGANIZATION_CONTRIBUTOR,
124+
organizationRole: USER_ROLE.ORGANIZATION_CONTRIBUTOR,
125125
} as const;
126126

127127
await membersPage.editMember(updatedWorkspaceAdminMember);
@@ -132,7 +132,7 @@ test.describe('Members management suite', () => {
132132
...organizationContributorMember,
133133
firstName: 'Updated',
134134
lastName: 'Old Contributor',
135-
role: USER_ROLE.ORGANIZATION_ADMIN,
135+
organizationRole: USER_ROLE.ORGANIZATION_ADMIN,
136136
} as const;
137137

138138
await membersPage.editMember(updatedWorkspaceContributorMember);

web_ui/tests/features/profile-page/members.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ test.describe('Members page', () => {
371371
email: editedOrganizationAdmin.email,
372372
firstName: editedOrganizationAdmin.firstName,
373373
lastName: editedOrganizationAdmin.secondName,
374-
role: USER_ROLE.ORGANIZATION_CONTRIBUTOR,
374+
organizationRole: USER_ROLE.ORGANIZATION_CONTRIBUTOR,
375375
} as const;
376376
await membersPage.editMember(editedMember);
377377

@@ -428,7 +428,7 @@ test.describe('Members page', () => {
428428
email: editedOrganizationContributor.email,
429429
firstName: editedOrganizationContributor.firstName,
430430
lastName: editedOrganizationContributor.secondName,
431-
role: USER_ROLE.ORGANIZATION_ADMIN,
431+
organizationRole: USER_ROLE.ORGANIZATION_ADMIN,
432432
} as const;
433433

434434
await expect(
@@ -502,7 +502,7 @@ test.describe('Members page', () => {
502502
email: editedWorkspaceAdmin2.email,
503503
firstName: editedWorkspaceAdmin2.firstName,
504504
lastName: editedWorkspaceAdmin2.secondName,
505-
role: USER_ROLE.ORGANIZATION_CONTRIBUTOR,
505+
organizationRole: USER_ROLE.ORGANIZATION_CONTRIBUTOR,
506506
} as const;
507507

508508
await membersPage.editMember(editedMember);
@@ -576,7 +576,7 @@ test.describe('Members page', () => {
576576
email: editedOrganizationContributor.email,
577577
firstName: editedOrganizationContributor.firstName,
578578
lastName: editedOrganizationContributor.secondName,
579-
role: USER_ROLE.ORGANIZATION_ADMIN,
579+
organizationRole: USER_ROLE.ORGANIZATION_ADMIN,
580580
} as const;
581581

582582
await membersPage.editMember(editedMember);

web_ui/tests/fixtures/page-objects/members-page.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export class MembersPage {
121121
await this.searchByNameOrEmailField.fill('');
122122
}
123123

124-
async editMember(member: { email: string; firstName?: string; lastName?: string; role?: USER_ROLE }) {
124+
async editMember(member: { email: string; firstName?: string; lastName?: string; organizationRole?: USER_ROLE }) {
125125
await this.getActionMenuButton(member.email).click();
126126

127127
await this.page.getByRole('menuitem', { name: /edit/i }).click();
@@ -134,9 +134,9 @@ export class MembersPage {
134134
await this.page.getByRole('textbox', { name: /last name/i }).fill(member.lastName);
135135
}
136136

137-
if (member.role !== undefined) {
137+
if (member.organizationRole !== undefined) {
138138
await this.page.getByTestId('roles-add-user').click();
139-
await this.page.getByRole('option', { name: member.role }).click();
139+
await this.page.getByRole('option', { name: member.organizationRole }).click();
140140
}
141141

142142
await this.page.getByRole('button', { name: /save/i }).click();

0 commit comments

Comments
 (0)