Skip to content

Commit 8fab795

Browse files
committed
Get rid of unnecessary customQueryClient prop
1 parent dfe480c commit 8fab795

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

web_ui/src/providers/query-client-provider/query-client-provider.component.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,9 @@ export const createGetiQueryClient = ({
9090
export const QueryClientProvider = ({
9191
children,
9292
defaultQueryOptions,
93-
customQueryClient,
9493
}: {
9594
children: ReactNode;
9695
defaultQueryOptions?: DefaultOptions;
97-
customQueryClient?: QueryClient;
9896
}) => {
9997
const { addNotification } = useNotification();
10098

@@ -106,12 +104,8 @@ export const QueryClientProvider = ({
106104
}, [addNotification]);
107105

108106
const queryClient = useMemo(() => {
109-
if (customQueryClient) {
110-
return customQueryClient;
111-
}
112-
113107
return createGetiQueryClient({ addNotification, defaultQueryOptions });
114-
}, [addNotification, customQueryClient, defaultQueryOptions]);
108+
}, [addNotification, defaultQueryOptions]);
115109

116110
return (
117111
<TanstackQueryClientProvider client={queryClient}>

web_ui/src/test-utils/required-providers-render.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,14 @@ import {
1111
} from '@geti/core/src/services/application-services-provider.component';
1212
import { OnboardingProfile } from '@geti/core/src/users/services/onboarding-service.interface';
1313
import { defaultTheme, IntelBrandedLoading, Provider as ThemeProvider } from '@geti/ui';
14+
import { QueryClientProvider } from '@tanstack/react-query';
1415
import { render, RenderOptions, RenderResult } from '@testing-library/react';
1516
import { AuthProvider } from 'react-oidc-context';
1617
import { MemoryRouter as Router } from 'react-router-dom';
1718

1819
import { AccountStatusDTO } from '../core/organizations/dtos/organizations.interface';
1920
import { NotificationProvider, Notifications, useNotification } from '../notification/notification.component';
20-
import {
21-
createGetiQueryClient,
22-
QueryClientProvider,
23-
} from '../providers/query-client-provider/query-client-provider.component';
21+
import { createGetiQueryClient } from '../providers/query-client-provider/query-client-provider.component';
2422
import { TusUploadProvider } from '../providers/tus-upload-provider/tus-upload-provider.component';
2523
import { getMockedWorkspace } from './mocked-items-factory/mocked-workspace';
2624

@@ -79,7 +77,7 @@ const PrefilledQueryClientProvider = ({
7977
return client;
8078
}, [addNotification, featureFlags, profile]);
8179

82-
return <QueryClientProvider customQueryClient={prefilledQueryClient}>{children}</QueryClientProvider>;
80+
return <QueryClientProvider client={prefilledQueryClient}>{children}</QueryClientProvider>;
8381
};
8482

8583
export const RequiredProviders = ({

0 commit comments

Comments
 (0)