Skip to content

Commit a838fc0

Browse files
committed
Fix test and tsc issue
1 parent ebc12f2 commit a838fc0

File tree

5 files changed

+31
-15
lines changed

5 files changed

+31
-15
lines changed

web_ui/src/pages/annotator/providers/prediction-provider/use-inference-server-status.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { useApplicationServices } from '@geti/core/src/services/application-serv
66
import { useQuery, UseQueryResult } from '@tanstack/react-query';
77
import { AxiosError } from 'axios';
88

9-
import { InferenceServerStatusResult } from '../../../../core/annotations/services/prediction-service.interface';
9+
import { InferenceServerStatusResult } from '../../../../core/annotations/services/inference-service.interface';
1010
import { ProjectIdentifier } from '../../../../core/projects/core.interface';
1111
import { useTask } from '../task-provider/task-provider.component';
1212

web_ui/src/pages/annotator/providers/selected-media-item-provider/default-selected-media-item-provider.component.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,8 @@ import QUERY_KEYS from '@geti/core/src/requests/query-keys';
77
import { useQuery, UseQueryResult } from '@tanstack/react-query';
88
import { noop } from 'lodash-es';
99

10-
import {
11-
ExplanationResult,
12-
PredictionResult,
13-
} from '../../../../core/annotations/services/prediction-service.interface';
10+
import { ExplanationResult } from '../../../../core/annotations/services/inference-service.interface';
11+
import { PredictionResult } from '../../../../core/annotations/services/prediction-service.interface';
1412
import { SelectedMediaItemContext, SelectedMediaItemProps } from './selected-media-item-provider.component';
1513
import { SelectedMediaItem } from './selected-media-item.interface';
1614

web_ui/src/pages/annotator/providers/selected-media-item-provider/use-explanation-query.hook.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,19 @@ export const useExplanationsQuery = ({
3636
queryFn: async ({ signal }) => {
3737
if (!mediaItem) throw new Error("Can't fetch undefined media item");
3838

39-
return await inferenceService.getExplanations(datasetIdentifier, mediaItem, taskId, undefined, signal);
39+
try {
40+
const explanations = await inferenceService.getExplanations(
41+
datasetIdentifier,
42+
mediaItem,
43+
taskId,
44+
undefined,
45+
signal
46+
);
47+
48+
return explanations ?? [];
49+
} catch (_error) {
50+
return [];
51+
}
4052
},
4153
enabled: enabled && !!mediaItem,
4254
staleTime: 5 * 60_000,

web_ui/src/pages/project-details/components/project-test/test-details-preview/use-test-results-query.hook.test.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,8 @@ describe('useTestResultsQuery', () => {
8080
await waitFor(() => {
8181
expect(mockedInferenceService.getExplanations).toHaveBeenCalled();
8282
expect(mockedInferenceService.getTestPredictions).toHaveBeenCalled();
83-
expect(result.current.predictionsQuery.data).toEqual({ annotations: [mockAnnotation], maps: [] });
83+
expect(result.current.predictionsQuery.data).toEqual({ annotations: [mockAnnotation] });
84+
expect(result.current.explanationsQuery.data).toEqual([]);
8485
});
8586
});
8687

@@ -103,7 +104,8 @@ describe('useTestResultsQuery', () => {
103104
await waitFor(() => {
104105
expect(mockedInferenceService.getExplanations).toHaveBeenCalled();
105106
expect(mockedInferenceService.getTestPredictions).toHaveBeenCalled();
106-
expect(result.current.predictionsQuery.data).toEqual({ annotations: [], maps: [mockedExplanation] });
107+
expect(result.current.predictionsQuery.data).toEqual({ annotations: [] });
108+
expect(result.current.explanationsQuery.data).toEqual([mockedExplanation]);
107109
});
108110
});
109111
});

web_ui/src/pages/project-details/components/project-test/test-details-preview/use-test-results-query.hook.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,18 @@ export const useTestResultsQuery = (
7373
const predictionsQuery = useQuery<PredictionResult, AxiosError>({
7474
queryKey: QUERY_KEYS.TEST_PREDICTIONS(projectIdentifier, testId, String(testResult?.predictionId)),
7575
queryFn: async () => {
76-
const predictions = await inferenceService.getTestPredictions(
77-
datasetIdentifier,
78-
labels,
79-
testId,
80-
String(testResult?.predictionId)
81-
);
76+
try {
77+
const predictions = await inferenceService.getTestPredictions(
78+
datasetIdentifier,
79+
labels,
80+
testId,
81+
String(testResult?.predictionId)
82+
);
8283

83-
return { annotations: predictions };
84+
return { annotations: predictions ?? [] };
85+
} catch (_error) {
86+
return { annotations: [] };
87+
}
8488
},
8589
enabled: isNonEmptyString(testResult?.predictionId),
8690
});

0 commit comments

Comments
 (0)