Skip to content

Commit c29354e

Browse files
committed
Update consumers
1 parent ccc470f commit c29354e

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

web_ui/src/pages/landing-page/workspaces-tabs/workspaces-tabs.component.tsx

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -69,15 +69,6 @@ export const WorkspacesTabs = () => {
6969
selectedKey={selectedWorkspaceId}
7070
onSelectionChange={handleSelectWorkspace}
7171
renderTabItem={(workspace) => <WorkspaceTabItem workspace={workspace} />}
72-
renderTabPanel={() => (
73-
<HasPermission
74-
operations={[OPERATION.CAN_SEE_WORKSPACE]}
75-
specialCondition={!FEATURE_FLAG_WORKSPACE_ACTIONS || undefined}
76-
Fallback={<NoPermissionPlaceholder />}
77-
>
78-
<Workspace />
79-
</HasPermission>
80-
)}
8172
addButton={
8273
FEATURE_FLAG_WORKSPACE_ACTIONS ? (
8374
<TooltipTrigger placement='bottom'>
@@ -95,7 +86,15 @@ export const WorkspacesTabs = () => {
9586
) : undefined
9687
}
9788
ariaLabel={'Workspaces tabs'}
98-
/>
89+
>
90+
<HasPermission
91+
operations={[OPERATION.CAN_SEE_WORKSPACE]}
92+
specialCondition={!FEATURE_FLAG_WORKSPACE_ACTIONS || undefined}
93+
Fallback={<NoPermissionPlaceholder />}
94+
>
95+
<Workspace />
96+
</HasPermission>
97+
</ManagedTabs>
9998
<CreateWorkspaceDialog
10099
triggerState={createWorkspaceDialogState}
101100
names={workspacesNames}

web_ui/src/pages/project-details/components/project-dataset/project-dataset.component.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ export const ProjectDataset = () => {
5454
selectedKey={selectedDataset.id}
5555
onSelectionChange={(key) => handleSelectDataset(String(key))}
5656
renderTabItem={(dataset) => <ProjectDatasetTabActions dataset={dataset} />}
57-
renderTabPanel={(dataset) => <DatasetTabPanel dataset={dataset} />}
5857
addButton={
5958
<TooltipTrigger placement='bottom'>
6059
<ActionButton
@@ -75,7 +74,9 @@ export const ProjectDataset = () => {
7574
onCollapsedItemSelect: handleSelectDataset,
7675
}}
7776
ariaLabel={'Dataset page tabs'}
78-
/>
77+
>
78+
<DatasetTabPanel dataset={selectedDataset} />
79+
</ManagedTabs>
7980
<ExportDatasetDialog triggerState={exportDialogState} datasetName={selectedDataset.name} />
8081
</Flex>
8182
);

web_ui/src/pages/user-management/workspaces/workspace-users-toolbar.component.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ export const WorkspaceUsersToolbar = ({
7878

7979
return <CustomTabItem isMoreIconVisible={false} name={workspace.name} />;
8080
}}
81-
renderTabPanel={() => <></>}
8281
addButton={
8382
FEATURE_FLAG_WORKSPACE_ACTIONS ? (
8483
<TooltipTrigger placement='bottom'>

0 commit comments

Comments
 (0)