Skip to content

Commit d940252

Browse files
authored
ITEP-32138 Tiling follow up [PART 7] (#507)
1 parent 6aee001 commit d940252

File tree

3 files changed

+14
-15
lines changed

3 files changed

+14
-15
lines changed

web_ui/src/pages/project-details/components/project-models/train-model-dialog/advanced-settings/data-management/data-management.component.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,11 @@ const getAugmentationParameters = (configuration: TrainingConfiguration) => {
2727
return augmentation;
2828
};
2929

30-
const getTilingParameters = (configuration: TrainingConfiguration) => {
31-
return configuration.datasetPreparation.augmentation.tiling;
32-
};
33-
3430
export const DataManagement: FC<DataManagementProps> = ({ trainingConfiguration, onUpdateTrainingConfiguration }) => {
35-
const tilingParameters = getTilingParameters(trainingConfiguration);
3631
const augmentationParameters = getAugmentationParameters(trainingConfiguration);
3732
const subsetSplitParameters = trainingConfiguration.datasetPreparation.subsetSplit;
3833
const filteringParameters = trainingConfiguration.datasetPreparation.filtering;
34+
const tilingParameters = trainingConfiguration.datasetPreparation.augmentation.tiling;
3935

4036
return (
4137
<View>

web_ui/src/pages/project-details/components/project-models/train-model-dialog/advanced-settings/data-management/tiling/tiling-modes.component.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import styles from './tiling.module.scss';
1111

1212
export enum TILING_MODES {
1313
OFF = 'Off',
14-
ADAPTIVE = 'Adaptive',
15-
MANUAL = 'Manual',
14+
AUTOMATIC = 'Automatic',
15+
CUSTOM = 'Custom',
1616
}
1717

1818
const TilingModeTooltip: FC = () => {
@@ -36,7 +36,7 @@ export const TilingModes: FC<TilingModesProps> = ({ selectedTilingMode, onTiling
3636
Tiling mode <TilingModeTooltip />
3737
</Text>
3838
<ToggleButtons
39-
options={[TILING_MODES.OFF, TILING_MODES.ADAPTIVE, TILING_MODES.MANUAL]}
39+
options={[TILING_MODES.OFF, TILING_MODES.AUTOMATIC, TILING_MODES.CUSTOM]}
4040
selectedOption={selectedTilingMode}
4141
onOptionChange={onTilingModeChange}
4242
/>

web_ui/src/pages/project-details/components/project-models/train-model-dialog/advanced-settings/data-management/tiling/tiling.component.tsx

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ const getTilingMode = (tilingParameters: ConfigurationParameter[]): TILING_MODES
5555
}
5656

5757
if (adaptive?.value === true) {
58-
return TILING_MODES.ADAPTIVE;
58+
return TILING_MODES.AUTOMATIC;
5959
}
6060

61-
return TILING_MODES.MANUAL;
61+
return TILING_MODES.CUSTOM;
6262
};
6363

6464
export const Tiling: FC<TilingProps> = ({ tilingParameters, onUpdateTrainingConfiguration }) => {
@@ -103,13 +103,16 @@ export const Tiling: FC<TilingProps> = ({ tilingParameters, onUpdateTrainingConf
103103
return;
104104
}
105105

106-
if (tilingMode === TILING_MODES.ADAPTIVE) {
106+
if (tilingMode === TILING_MODES.AUTOMATIC) {
107107
handleUpdateTilingParameter([
108108
{ ...enableParameter, value: true },
109109
{ ...adaptiveParameter, value: true },
110110
]);
111111
} else if (tilingMode === TILING_MODES.OFF) {
112-
handleUpdateTilingParameter({ ...enableParameter, value: false });
112+
handleUpdateTilingParameter([
113+
{ ...enableParameter, value: false },
114+
{ ...adaptiveParameter, value: false },
115+
]);
113116
} else {
114117
handleUpdateTilingParameter([
115118
{ ...enableParameter, value: true },
@@ -127,13 +130,13 @@ export const Tiling: FC<TilingProps> = ({ tilingParameters, onUpdateTrainingConf
127130
</Text>
128131
),
129132

130-
[TILING_MODES.ADAPTIVE]: (
133+
[TILING_MODES.AUTOMATIC]: (
131134
<View UNSAFE_className={styles.tilingModeDescription} gridColumn={'2/3'}>
132-
Adaptive means that the system will automatically set the parameters based on the images resolution and
135+
It means that the system will automatically set the parameters based on the images resolution and
133136
annotations size.
134137
</View>
135138
),
136-
[TILING_MODES.MANUAL]: (
139+
[TILING_MODES.CUSTOM]: (
137140
<View gridColumn={'1/-1'}>
138141
<Parameters parameters={manualTilingParameters} onChange={handleUpdateTilingParameter} />
139142
</View>

0 commit comments

Comments
 (0)