Skip to content

Move from CoachMark to FuxNotification #918

@romanowska

Description

@romanowska

Motivation:

This bug was brought to our attention - dismiss button is unreachable, notification should flip when there's not enough space to show it.

Image

As the CoachMark component doesn't support flipping, after a conversation there was a decision to resign from it and use FuxNotification instead, which is using Popover underneath, supporting automatic notification flipping.

The previous issue with Popover was that it is closing automatically which was not what we wanted. In the meantime we discovered that adding isKeyboardDismissDisabled prevents that default behaviour and is not blocking us from using it anymore.

To do:

  1. Add isKeyboardDismissDisabled to FuxNotification component to prevent it from closing the notification when clicking/tapping in the background - only close button, dismiss button or dismiss all should do that.
  2. Change all occurances of CoachMark to use FuxNotification instead
  3. Fix tests
  4. Fix Learn more button on CreditBalanceButton notification: 1. wrong link 2. it should be displayed only for the project it concerns

Known issue:

Popover implementation calculates the tip position automatically which sometimes may be different from what we want but overall the pros are stronger than cons for using it as implementation.

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions