Fix hpo converter (#3940)

* save best hp after hpo

* add test

Author: eunwoosh

src/otx/engine/hpo/hpo_api.py

@@ -6,6 +6,7 @@
 from __future__ import annotations
 
 import dataclasses
+import json
 import logging
 import time
 from functools import partial
@@ -128,6 +129,10 @@ def execute_hpo(
     hpo_algo.print_result()
     _remove_unused_model_weights(hpo_workdir, best_hpo_weight)
 
+    if best_config is not None:
+        with (hpo_workdir / "best_hp.json").open("w") as f:
+            json.dump(best_config, f)
+
     return best_config, best_hpo_weight
 
 

src/otx/tools/converter.py

@@ -202,6 +202,8 @@ def convert(config_path: str, task: OTXTaskType | None = None) -> dict:
             task_info["task"] = task
         default_config = ConfigConverter._get_default_config(task_info)
         ConfigConverter._update_params(default_config, param_dict)
+        if (hpo_time_ratio := template_config.get("hpo_parameters", {}).get("hpo_time_ratio")) is not None:
+            default_config["hpo_config.expected_time_ratio"] = hpo_time_ratio
         ConfigConverter._remove_unused_key(default_config)
         return default_config
 

tests/unit/engine/hpo/test_hpo_api.py

@@ -148,6 +148,7 @@ def test_execute_hpo(
 
     # check hpo workdir exists
     assert (engine_work_dir / "hpo").exists()
+    assert (engine_work_dir / "hpo" / "best_hp.json").exists()
     # check a case where progress_update_callback exists
     mock_thread.assert_called_once()
     assert mock_thread.call_args.kwargs["target"] == _update_hpo_progress