Skip to content

Commit 1fced5a

Browse files
authored
Fix Learning Rate and Loss Handling in Tile Classifier MaskRCNN EfficientNet (#3873)
* fixes * add test case
1 parent 7bdf708 commit 1fced5a

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/otx/algorithms/detection/adapters/mmdet/models/detectors/custom_maskrcnn_tile_optimized.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,8 @@ def forward_train(
149149
img, img_metas, gt_bboxes, gt_labels, gt_bboxes_ignore, gt_masks, proposals, **kwargs
150150
)
151151
losses.update(rcnn_loss)
152+
if "acc" in losses:
153+
losses.pop("acc")
152154
return losses
153155

154156
@staticmethod

src/otx/algorithms/detection/adapters/mmdet/utils/config_utils.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,11 +122,8 @@ def patch_tiling(config, hparams, dataset=None):
122122

123123
if config.model.backbone.type == "efficientnet_b2b":
124124
learning_rate = 0.002
125-
logger.info(
126-
f"Patched {config.model.backbone.type} LR: "
127-
f"{hparams.learning_parameters.learning_rate} -> {learning_rate}"
128-
)
129-
hparams.learning_parameters.learning_rate = learning_rate
125+
logger.info(f"Patched {config.model.backbone.type} LR: " f"{config.optimizer.lr} -> {learning_rate}")
126+
config.optimizer.lr = learning_rate
130127

131128
config.data.train.filter_empty_gt = False
132129

tests/unit/algorithms/detection/tiling/test_tiling_tile_classifier.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,3 +211,4 @@ def test_patch_tiling_func(self):
211211
hyper_parameters.tiling_parameters.enable_tiling = True
212212
hyper_parameters.tiling_parameters.enable_tile_classifier = True
213213
patch_tiling(cfg, hyper_parameters, self.dataset)
214+
assert cfg.optimizer.lr == 0.002, "Learning rate should be 0.002 when MRCNN EfficientNet is used"

0 commit comments

Comments
 (0)