Training Configurations Add/Update implementation (#4873)

Co-authored-by: Leonardo Lai <[email protected]>

Author: A-Artemis

application/backend/app/alembic/versions/2786b50eb5a4_schema.py

@@ -156,6 +156,19 @@ def upgrade() -> None:
         sa.ForeignKeyConstraint(["label_id"], ["labels.id"], ondelete="CASCADE"),
         sa.PrimaryKeyConstraint("dataset_item_id", "label_id"),
     )
+    op.create_table(
+        "training_configurations",
+        sa.Column("id", sa.Text(), nullable=False),
+        sa.Column("project_id", sa.Text(), nullable=False),
+        sa.Column("model_architecture_id", sa.String(length=255), nullable=True),
+        sa.Column("configuration_data", sa.JSON(), nullable=False),
+        sa.Column("created_at", sa.DateTime(), server_default=sa.text("(CURRENT_TIMESTAMP)"), nullable=False),
+        sa.Column("updated_at", sa.DateTime(), server_default=sa.text("(CURRENT_TIMESTAMP)"), nullable=False),
+        sa.ForeignKeyConstraint(["project_id"], ["projects.id"], ondelete="CASCADE"),
+        sa.PrimaryKeyConstraint("id"),
+        sa.UniqueConstraint("project_id", "model_architecture_id", name="uq_project_model_config"),
+    )
+
     # ### end Alembic commands ###
 
 
@@ -177,5 +190,6 @@ def downgrade() -> None:
     op.drop_table("sources")
     op.drop_table("sinks")
     op.drop_index("idx_projects_name", table_name="projects")
+    op.drop_table("training_configurations")
     op.drop_table("projects")
     # ### end Alembic commands ###

application/backend/app/api/dependencies.py

@@ -30,6 +30,7 @@
 from app.services.data_collect import DataCollector
 from app.services.event.event_bus import EventBus
 from app.services.label_service import LabelService
+from app.services.training_configuration_service import TrainingConfigurationService
 from app.webrtc.manager import WebRTCManager
 
 
@@ -268,3 +269,8 @@ def get_base_weights_service(data_dir: Annotated[Path, Depends(get_data_dir)]) -
 def get_job_queue(request: Request) -> JobQueue:
     """Provides the global JobQueue instance from FastAPI application's state."""
     return request.app.state.job_queue
+
+
+def get_training_configuration_service(db: Annotated[Session, Depends(get_db)]) -> TrainingConfigurationService:
+    """Provides a TrainingConfigurationService instance for managing training configurations."""
+    return TrainingConfigurationService(db_session=db)

application/backend/app/api/routers/projects.py

@@ -6,13 +6,13 @@
 from typing import Annotated
 from uuid import UUID
 
-from fastapi import APIRouter, Body, Depends, Query, status
+from fastapi import APIRouter, Body, Depends, status
 from fastapi.exceptions import HTTPException
 from fastapi.openapi.models import Example
 from starlette.responses import FileResponse
 
 from app.api.dependencies import get_data_collector, get_label_service, get_project, get_project_id, get_project_service
-from app.schemas import LabelView, PatchLabels, ProjectCreate, ProjectUpdateName, ProjectView, TrainingConfiguration
+from app.schemas import LabelView, PatchLabels, ProjectCreate, ProjectUpdateName, ProjectView
 from app.services import (
     LabelService,
     ProjectService,
@@ -22,7 +22,6 @@
 )
 from app.services.data_collect import DataCollector
 from app.services.label_service import DuplicateLabelsError
-from app.supported_models.hyperparameters import Hyperparameters
 
 router = APIRouter(prefix="/api/projects", tags=["Projects"])
 
@@ -277,82 +276,3 @@ def capture_next_pipeline_frame(
         data_collector.collect_next_frame()
     except ResourceNotFoundError as e:
         raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=str(e))
-
-
-@router.get(
-    "/{project_id}/training_configuration",
-    response_model=TrainingConfiguration,
-    responses={
-        status.HTTP_200_OK: {"description": "Training configuration found"},
-        status.HTTP_400_BAD_REQUEST: {"description": "Invalid project ID or query parameters"},
-        status.HTTP_404_NOT_FOUND: {"description": "Project not found"},
-    },
-)
-def get_training_configuration(
-    project_id: Annotated[UUID, Depends(get_project_id)],
-    project_service: Annotated[ProjectService, Depends(get_project_service)],
-    model_architecture_id: Annotated[str | None, Query()] = None,
-    model_revision_id: Annotated[UUID | None, Query()] = None,
-) -> TrainingConfiguration:
-    """
-    Get the training configuration for a project.
-
-    - If model_architecture_id is provided, returns configuration for that specific model architecture.
-    - If model_revision_id is provided, returns configuration for a specific trained model.
-    - If neither is provided, returns only general task-related configuration.
-    Note: model_architecture_id and model_revision_id cannot be used together.
-
-    Args:
-        project_id (UUID): The unique identifier of the project.
-        project_service (ProjectService): The project service
-        model_architecture_id (Optional[str]): The model architecture ID for specific configuration retrieval.
-        model_revision_id (Optional[UUID]): The model revision ID for specific configuration retrieval.
-
-    Returns:
-        TrainingConfiguration: The training configuration details.
-    """
-    try:
-        # TODO: Implement actual training configuration retrieval logic
-        _ = project_id, project_service, model_architecture_id, model_revision_id
-        return TrainingConfiguration.from_hyperparameters(hyperparameters=Hyperparameters())
-    except ResourceNotFoundError as e:
-        raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=str(e))
-    except ValueError as e:
-        raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail=str(e))
-
-
-@router.patch(
-    "/{project_id}/training_configuration",
-    status_code=status.HTTP_204_NO_CONTENT,
-    responses={
-        status.HTTP_204_NO_CONTENT: {"description": "Training configuration updated successfully"},
-        status.HTTP_400_BAD_REQUEST: {"description": "Invalid project ID, query parameters, or request body"},
-        status.HTTP_404_NOT_FOUND: {"description": "Project not found"},
-    },
-)
-def update_training_configuration(
-    project_id: Annotated[UUID, Depends(get_project_id)],
-    training_config_update: Annotated[TrainingConfiguration, Body(description="Training configuration updates")],
-    project_service: Annotated[ProjectService, Depends(get_project_service)],
-    model_architecture_id: Annotated[str | None, Query()] = None,
-) -> None:
-    """
-    Update the training configuration for a project.
-
-    - If model_architecture_id is provided, updates configuration for that specific model architecture.
-    - If not provided, updates the general task-related configuration.
-    Note: model_architecture_id cannot be used with model_revision_id for updates.
-
-    Args:
-        project_id (UUID): The unique identifier of the project.
-        training_config_update (TrainingConfiguration): The training configuration updates.
-        project_service (ProjectService): The project service
-        model_architecture_id (Optional[str]): The model architecture ID for specific configuration update.
-    """
-    try:
-        # TODO: Implement actual training configuration update logic
-        _ = project_id, training_config_update, project_service, model_architecture_id
-    except ResourceNotFoundError as e:
-        raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=str(e))
-    except ValueError as e:
-        raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail=str(e))

application/backend/app/api/routers/training_configurations.py

@@ -0,0 +1,74 @@
+# Copyright (C) 2025 Intel Corporation
+# SPDX-License-Identifier: Apache-2.0
+
+from typing import Annotated
+from uuid import UUID
+
+from fastapi import APIRouter, Depends, HTTPException, Query, status
+
+from app.api.dependencies import get_project_id, get_training_configuration_service
+from app.api.serializers.configurable_parameters import ConfigurableParametersConverter
+from app.api.serializers.training_configuration import TrainingConfigurationConverter
+from app.services import ResourceNotFoundError
+from app.services.training_configuration_service import TrainingConfigurationService
+
+router = APIRouter(prefix="/api/projects/{project_id}/training_configuration", tags=["Training Configuration"])
+
+
+@router.get("")
+def get_training_configuration(
+    training_configuration_service: Annotated[
+        TrainingConfigurationService, Depends(get_training_configuration_service)
+    ],
+    project_id: Annotated[UUID, Depends(get_project_id)],
+    model_architecture_id: Annotated[str | None, Query()] = None,
+    model_revision_id: Annotated[UUID | None, Query()] = None,
+) -> dict:
+    """
+    Get the training configuration for a project.
+
+    If model_architecture_id is provided, returns configuration for that specific model architecture.
+    If model_revision_id is provided, returns configuration for a specific trained model.
+    If neither is provided, returns only general task-related configuration.
+    Note: model_architecture_id and model_revision_id cannot be used together.
+    """
+    try:
+        training_config = training_configuration_service.get_training_configuration(
+            project_id=project_id,
+            model_architecture_id=model_architecture_id,
+            model_revision_id=model_revision_id,
+        )
+        return TrainingConfigurationConverter().training_configuration_to_rest(training_configuration=training_config)
+    except ResourceNotFoundError as e:
+        raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=str(e))
+    except ValueError as e:
+        raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail=str(e))
+
+
+@router.patch("", status_code=status.HTTP_200_OK)
+def update_training_configuration(
+    training_configuration_service: Annotated[
+        TrainingConfigurationService, Depends(get_training_configuration_service)
+    ],
+    project_id: Annotated[UUID, Depends(get_project_id)],
+    training_config_update: dict,
+    model_architecture_id: Annotated[str | None, Query()] = None,
+) -> dict:
+    """
+    Update the training configuration for a project.
+
+    - If model_architecture_id is provided, updates configuration for that specific model architecture.
+    - If not provided, updates the general task-related configuration.
+    """
+    try:
+        converted_config = ConfigurableParametersConverter.configurable_parameters_from_rest(training_config_update)
+        updated_config = training_configuration_service.update_training_configuration(
+            project_id=project_id,
+            training_config_update=converted_config,
+            model_architecture_id=model_architecture_id,
+        )
+        return TrainingConfigurationConverter().training_configuration_to_rest(updated_config)
+    except ResourceNotFoundError as e:
+        raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=str(e))
+    except ValueError as e:
+        raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail=str(e))

application/backend/app/api/serializers/__init__.py

@@ -0,0 +1,2 @@
+# Copyright (C) 2025 Intel Corporation
+# SPDX-License-Identifier: Apache-2.0