Fix 'None' node issue in label schema mapping in case of label deletion (develop) (#2308)

Signed-off-by: Songki Choi <[email protected]>

Author: Songki Choi

src/otx/api/serialization/label_mapper.py

@@ -139,9 +139,13 @@ def backward(instance: dict, all_labels: Dict[ID, LabelEntity]) -> LabelTree:
 
         label_map = {label_id: all_labels.get(IDMapper().backward(label_id)) for label_id in instance["nodes"]}
         for label in label_map.values():
-            output.add_node(label)
+            if label:
+                output.add_node(label)
         for edge in instance["edges"]:
-            output.add_edge(label_map[edge[0]], label_map[edge[1]])
+            node1 = label_map.get(edge[0])
+            node2 = label_map.get(edge[1])
+            if node1 and node2:
+                output.add_edge(node1, node2)
 
         return output
 

tests/unit/api/serialization/test_label_mapper.py

@@ -325,3 +325,30 @@ def test_label_graph_backward(self):
         }
         with pytest.raises(ValueError):
             LabelTreeMapper.backward(instance=forward, all_labels=labels)
+        # Checking label deletion case
+        forward = {
+            "type": "tree",
+            "directed": True,
+            "nodes": ["0", "0_1", "0_2", "0_1_1", "0_2_1"],
+            "edges": [("0_1", "0"), ("0_2", "0"), ("0_1_1", "0_1"), ("0_2_1", "0_2")],
+        }
+        labels = {
+            ID("0"): self.label_0,
+            ID("0_1"): self.label_0_1,
+            # ID("0_2"): self.label_0_2,
+            ID("0_1_1"): self.label_0_1_1,
+            # ID("0_1_2"): self.label_0_1_2,
+            ID("0_2_1"): self.label_0_2_1,
+        }
+        expected_backward = LabelTree()
+        for node in labels.values():
+            expected_backward.add_node(node)
+        for parent, child in [
+            (self.label_0, self.label_0_1),
+            # (self.label_0, self.label_0_2),
+            (self.label_0_1, self.label_0_1_1),
+            # (self.label_0_2, self.label_0_2_1),
+        ]:
+            expected_backward.add_child(parent, child)
+        actual_backward = LabelTreeMapper.backward(instance=forward, all_labels=labels)
+        assert LabelTreeMapper.forward(actual_backward) == LabelTreeMapper.forward(expected_backward)