Skip to content

Commit 8cbff51

Browse files
committed
Move 'Waiting for feedback' notification in the submission checker task
1 parent 53d861a commit 8cbff51

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

classes/listener/observer.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -127,16 +127,6 @@ public static function submit(\core\event\base $event) {
127127
'archive' => base64_encode($submitedfile->get_content()),
128128
);
129129

130-
// Remove previous feedback for the assignament
131-
$teachercommenttext = "Waiting for automatic feedback";
132-
133-
$data = new \stdClass();
134-
$data->attemptnumber = -1;
135-
$data->grade = -1;
136-
$data->assignfeedbackcomments_editor = ['text' => $teachercommenttext, 'format' => FORMAT_MOODLE];
137-
138-
$assign->save_grade($USER->id, $data);
139-
140130
$api = new \block_vmchecker\backend\api(get_config('block_vmchecker', 'backend'));
141131
$response = $api->submit($payload);
142132
if (empty($response)) {

classes/task/submission_checker.php

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,22 @@ public function execute() {
200200
break;
201201
case \block_vmchecker\backend\api::TASK_STATE_ERROR:
202202
$DB->delete_records('block_vmchecker_submissions', array('id' => $submission->id));
203+
break;
204+
default:
205+
// Remove previous feedback for the assignament
206+
$teachercommenttext = "Waiting for automatic feedback";
207+
208+
$data = new \stdClass();
209+
$data->attemptnumber = -1;
210+
$data->grade = -1;
211+
$data->assignfeedbackcomments_editor = ['text' => $teachercommenttext, 'format' => FORMAT_MOODLE];
212+
213+
$cm = get_coursemodule_from_instance('assign', $submission->assignid, 0, false, MUST_EXIST);
214+
$context = \context_module::instance($cm->id);
215+
216+
$assign = new \assign($context, null, null);
217+
$assign->save_grade($submission->userid, $data);
218+
203219
break;
204220
}
205221
}

0 commit comments

Comments
 (0)