Skip to content

Commit 530265e

Browse files
authored
Remove photo widgets (#1176)
IB-7691 Signed-off-by: Raul Metsma <raul@metsma.ee>
1 parent 5bd100f commit 530265e

21 files changed

+352
-1112
lines changed

client/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ add_executable(${PROJECT_NAME} WIN32 MACOSX_BUNDLE
3838
QPKCS11.cpp
3939
QSigner.cpp
4040
QSmartCard.cpp
41-
sslConnect.cpp
4241
Styles.cpp
4342
PrintSheet.cpp
4443
Settings.cpp

client/MainWindow.cpp

Lines changed: 2 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
#include "QSigner.h"
3131
#include "Settings.h"
3232
#include "Styles.h"
33-
#include "sslConnect.h"
3433
#include "TokenData.h"
3534
#include "effects/ButtonHoverFilter.h"
3635
#include "effects/FadeInNotification.h"
@@ -165,19 +164,7 @@ MainWindow::MainWindow( QWidget *parent )
165164
connect(ui->accordion, &Accordion::changePin1Clicked, this, &MainWindow::changePin1Clicked);
166165
connect(ui->accordion, &Accordion::changePin2Clicked, this, &MainWindow::changePin2Clicked);
167166
connect(ui->accordion, &Accordion::changePukClicked, this, &MainWindow::changePukClicked);
168-
connect(ui->infoStack, &InfoStack::photoClicked, this, &MainWindow::photoClicked);
169-
connect(ui->cardInfo, &CardWidget::photoClicked, this, &MainWindow::photoClicked); // To load photo
170167
connect(ui->cardInfo, &CardWidget::selected, ui->selector->selector, &DropdownButton::press);
171-
connect(SSLConnect::instance(), &SSLConnect::error, this, [this](const QString &error) {
172-
qWarning() << error;
173-
showNotification(tr("Loading picture failed."));
174-
});
175-
connect(SSLConnect::instance(), &SSLConnect::image, this, [this] (const QImage &image) {
176-
ui->infoStack->setProperty("PICTURE", image);
177-
QPixmap pixmap = QPixmap::fromImage(image);
178-
ui->cardInfo->showPicture(pixmap);
179-
ui->infoStack->showPicture(pixmap);
180-
});
181168

182169
updateSelectorData(qApp->signer()->tokensign());
183170
updateMyEID(qApp->signer()->tokensign());
@@ -853,6 +840,8 @@ void MainWindow::showCardMenu(bool show)
853840
{
854841
if(show)
855842
{
843+
if(ui->selector->list.isEmpty())
844+
return;
856845
auto *cardPopup = new CardPopup(ui->selector->list, this);
857846
connect(cardPopup, &CardPopup::activated, qApp->signer(), &QSigner::selectCard, Qt::QueuedConnection);
858847
connect(cardPopup, &CardPopup::activated, this, [this] { showCardMenu(false); }); // .. and hide card popup menu
@@ -944,27 +933,6 @@ void MainWindow::sign(F &&sign)
944933
adjustDrops();
945934
}
946935

947-
void MainWindow::photoClicked()
948-
{
949-
if(!ui->infoStack->property("PICTURE").isValid())
950-
{
951-
SSLConnect::instance()->fetch();
952-
return;
953-
}
954-
QString fileName = QStandardPaths::writableLocation(QStandardPaths::PicturesLocation);
955-
fileName += "/" + qApp->signer()->tokenauth().card();
956-
fileName = QFileDialog::getSaveFileName(this,tr("Save photo"), fileName,
957-
tr("Photo (*.jpg *.jpeg);;All Files (*)"));
958-
if(fileName.isEmpty())
959-
return;
960-
static const QStringList exts{QStringLiteral("jpg"), QStringLiteral("jpeg")};
961-
if(!exts.contains(QFileInfo(fileName).suffix(), Qt::CaseInsensitive))
962-
fileName.append(QStringLiteral(".jpg"));
963-
auto pix = ui->infoStack->property("PICTURE").value<QImage>();
964-
if(!pix.save(fileName))
965-
warnings->showWarning(DocumentModel::tr("Failed to save file '%1'").arg(fileName));
966-
}
967-
968936
void MainWindow::removeAddress(int index)
969937
{
970938
if(cryptoDoc)

client/MainWindow.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ private Q_SLOTS:
5555
void changePukClicked();
5656
void open(const QStringList &params, bool crypto, bool sign);
5757
void pageSelected(PageIcon *page);
58-
void photoClicked();
5958
void warningClicked(const QString &link);
6059

6160
protected:

client/MainWindow_MyEID.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@ void MainWindow::updateMyEID(const TokenData &t)
218218
}
219219
else
220220
{
221-
ui->infoStack->setProperty("PICTURE", QVariant());
222221
ui->infoStack->clearData();
223222
ui->accordion->clear();
224223
ui->myEid->invalidIcon(false);

client/common_enums.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ enum ContainerState {
3939
enum Actions {
4040
AddressAdd,
4141

42-
CardPhoto,
43-
4442
ContainerCancel,
4543
ContainerConvert,
4644
ContainerEncrypt,

client/images/icon_person_blue.svg

Lines changed: 0 additions & 16 deletions
This file was deleted.

client/images/images.qrc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
<file>icon_Krypto.svg</file>
4141
<file>icon_Minu_eID_hover.svg</file>
4242
<file>icon_Minu_eID.svg</file>
43-
<file>icon_person_blue.svg</file>
4443
<file>icon_radio.png</file>
4544
<file>icon_radio_checked.png</file>
4645
<file>icon_remove_hover.svg</file>

client/sslConnect.cpp

Lines changed: 0 additions & 143 deletions
This file was deleted.

client/sslConnect.h

Lines changed: 0 additions & 43 deletions
This file was deleted.

0 commit comments

Comments
 (0)