update new links to github, remove some ToDos

Author: Olesja Aarma

README.md

@@ -180,7 +180,7 @@ can do that.
     For Mobile-ID, user needs to enter mobile phone number additionally to identity code.
 13. Recipient finds `KeySharesCapsule` record from CDOC2 header where `recipient_id` matches 
     recipients entered identity code.   
-14. Recipient [prepares](https://open-eid.github.io/CDOC2/2.0-Draft/03_system_architecture/ch05_ID_authentication_protocol/#overview-of-the-generic-authentication-protocol) 
+14. Recipient [prepares](https://open-eid.github.io/CDOC2/2.0-Draft/03_system_architecture/ch06_ID_authentication_protocol/#overview-of-the-generic-authentication-protocol) 
     auth token by creating `nonce` for each share in [shares](https://github.com/open-eid/cdoc2-java-ref-impl/blob/a2dbe6711d88d2442e23d4ca80494f285f4d00cd/cdoc2-schema/src/main/fbs/recipients.fbs#L93). 
     `nonce` is created by using [`/key-shares/{shareId}/nonce`](https://github.com/open-eid/cdoc2-openapi/blob/55a0b02adae0d8c61f2589a47555a93e4cf31971/cdoc2-key-shares-openapi.yaml#L105)
     endpoint in each `cdoc2-shares-server`.

cdoc2-client/src/main/java/ee/cyber/cdoc2/client/ApiClientBuilder.java

@@ -39,8 +39,7 @@ public abstract class ApiClientBuilder {
     private boolean debug = false;
     private String userAgent = "cdoc2-client";
 
-    // ToDo. Basic authentication temporary fields for /key-shares. Remove when bearer auth
-    //  implemented. #2749
+    // used for monitoring API-s
     private String username;
     private String password;
 
@@ -118,15 +117,21 @@ public ApiClientBuilder withDebuggingEnabled(boolean enabled) {
         return this;
     }
 
-    // ToDo. Basic authentication temporary fields for /key-shares. Remove when bearer auth
-    //  implemented. #2749
+    /**
+     * Used for basic authentication for monitoring API-s
+     * @param xUsername username
+     * @return Builder for API client
+     */
     public ApiClientBuilder withUsername(String xUsername) {
         this.username = xUsername;
         return this;
     }
 
-    // ToDo. Basic authentication temporary fields for /key-shares. Remove when bearer auth
-    //  implemented. #2749
+    /**
+     * Used for basic authentication for monitoring API-s
+     * @param xPassword password
+     * @return Builder for API client
+     */
     public ApiClientBuilder withPassword(String xPassword) {
         this.password = xPassword;
         return this;

cdoc2-example-app/CDOC_DEVELOPER_GUIDE.md

@@ -101,7 +101,7 @@ with details for application configuration, keystore creation and monitoring.
 
 ### Server maven dependencies installation
 You should configure GitHub package repository access with Personal Access Token for getting
-[Open API](https://gitlab.ext.cyber.ee/cdoc2/cdoc2-java-ref-impl#maven-dependencies) and [Key 
+[Open API](https://github.com/open-eid/cdoc2-java-ref-impl#maven-dependencies) and [Key 
 Capsule Server](https://github.com/open-eid/cdoc2-capsule-server/blob/master/README.md#maven-dependencies)
 Maven dependencies.
 

test/config/shares-server/.env

@@ -20,7 +20,7 @@ DOCKER_REPOSITORY=open-eid
 # liquibase and shares-server should use the same version so they are built from same source and are compatible with each other
 # For GH workflows, built images version is release tag + commit hash
 # find latest version from https://github.com/orgs/open-eid/packages?ecosystem=container
-SHARES_SERVER_VERSION=0.4.1-snapshot.0-3553a87e54851276c82ee734eebcc207aaf90088
+SHARES_SERVER_VERSION=0.4.2-5e4a45f4b14f411fd78da2912e4018a68e28fe31
 # local builds will have version from cdoc2-shares-server/shares-server/pom.xml
 #SHARES_SERVER_VERSION=0.2.0-SNAPSHOT