Skip to content

Commit 7de9baf

Browse files
Merge pull request #671 from metsma/minizip
Fix minizip unicode support
2 parents a87ecb9 + fa189aa commit 7de9baf

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

examples/java/build.gradle

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,20 @@ jar {
1414
attributes 'Main-Class': 'ee.ria.libdigidocpp.libdigidocpp'
1515
}
1616
}
17-
def digidocppJarPath = file('/usr/share/digidocpp/digidocpp.jar').exists() ?
18-
'/usr/share/digidocpp/digidocpp.jar' :
19-
'/Library/Java/Extensions/digidocpp.jar'
17+
def digidocppJarPath = '/usr/share/digidocpp/digidocpp.jar'
18+
def nativeLibDir = null
19+
if (System.properties['os.name'].toLowerCase().contains('windows')) {
20+
digidocppJarPath = 'C:\\Program Files\\libdigidocpp\\digidocpp.jar'
21+
nativeLibDir = 'C:\\Program Files\\libdigidocpp'
22+
} else if (System.properties['os.name'].toLowerCase().contains('mac')) {
23+
digidocppJarPath = '/Library/Java/Extensions/digidocpp.jar'
24+
}
2025
dependencies {
2126
implementation files(digidocppJarPath)
27+
}
28+
tasks.withType(JavaExec).configureEach {
29+
if (nativeLibDir != null) {
30+
environment 'PATH', "${nativeLibDir};" + System.getenv('PATH')
31+
jvmArgs "-Djava.library.path=${nativeLibDir}"
32+
}
2233
}

src/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ if(TARGET PkgConfig::MINIZIP)
22
add_library(minizip ALIAS PkgConfig::MINIZIP)
33
else()
44
message(STATUS "MiniZip not found; using bundled copy.")
5-
add_library(minizip STATIC minizip/zip.c minizip/unzip.c minizip/ioapi.c $<$<C_COMPILER_ID:MSVC>:minizip/iowin32.c>)
5+
add_library(minizip STATIC minizip/zip.c minizip/unzip.c minizip/ioapi.c $<$<PLATFORM_ID:Windows>:minizip/iowin32.c>)
66
target_compile_options(minizip PRIVATE $<$<NOT:$<CXX_COMPILER_ID:MSVC>>:-Wno-unused-parameter -Wno-unused-value>)
7-
set_target_properties(minizip PROPERTIES COMPILE_DEFINITIONS "NOUNCRYPT;NOCRYPT" POSITION_INDEPENDENT_CODE YES)
7+
set_target_properties(minizip PROPERTIES POSITION_INDEPENDENT_CODE YES)
8+
target_compile_definitions(minizip PRIVATE NOUNCRYPT NOCRYPT $<$<PLATFORM_ID:Windows>:WIN32_LEAN_AND_MEAN UNICODE>)
89
target_link_libraries(minizip ZLIB::ZLIB)
910
endif()
1011

0 commit comments

Comments
 (0)