Skip to content

Commit 0b8aade

Browse files
authored
Website: Use 'Name' key in metadata for size (#112)
1 parent 68c5f0d commit 0b8aade

File tree

5 files changed

+7
-27
lines changed

5 files changed

+7
-27
lines changed

website-nextjs/src/components/admin/benchmark-detail/InstancesTableResult.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
getFacetedUniqueValues,
1313
useReactTable,
1414
} from "@tanstack/react-table"
15-
import { getInstance } from "@/utils/meta-data"
1615
import { MetaDataEntry } from "@/types/meta-data"
1716

1817
const InstancesTableResult = ({
@@ -72,10 +71,7 @@ const InstancesTableResult = ({
7271
temporalResolution: sizeData.temporalResolution,
7372
nOfVariables: sizeData.nOfVariables,
7473
nOfConstraints: sizeData.nOfConstraints,
75-
instance: getInstance(
76-
sizeData.temporalResolution.toString(),
77-
sizeData.spatialResolution.toString()
78-
),
74+
instance: sizeData.name,
7975
})),
8076
[benchmarkDetail.sizes.length]
8177
)

website-nextjs/src/pages/_app.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import resultActions from "@/redux/results/actions"
1111
import filterActions from "@/redux/filters/actions"
1212
import AdminLayout from "@/pages/AdminLayout"
1313
import { getBenchmarkResults, getLatestBenchmarkResult } from "@/utils/results"
14-
import { getInstance, getMetaData } from "@/utils/meta-data"
14+
import { getMetaData } from "@/utils/meta-data"
1515
import { BenchmarkResult } from "@/types/benchmark"
1616
import { IFilterState } from "@/types/state"
1717

@@ -29,10 +29,7 @@ function App({ Component, pageProps }: AppProps) {
2929
Object.keys(metaData).forEach((metaDataKey) => {
3030
metaData[metaDataKey].sizes.forEach((s) => {
3131
problemSizeResult[
32-
`${metaDataKey}'-'${getInstance(
33-
s.temporalResolution.toString(),
34-
s.spatialResolution.toString()
35-
)}`
32+
`${metaDataKey}'-'${s.name}`
3633
] = s.size
3734
})
3835
})

website-nextjs/src/redux/filters/actions.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import { BenchmarkResult } from "@/types/benchmark"
66
import { MetaData, MetaDataEntry, Size } from "@/types/meta-data"
77
import { getLatestBenchmarkResult } from "@/utils/results"
88
import { IFilterState } from "@/types/state"
9-
import { getInstance } from "@/utils/meta-data"
109

1110
const toggleFilter = (category: string, value: string, only: boolean) => {
1211
return {
@@ -56,10 +55,7 @@ const actions = {
5655
}
5756
results.rawMetaData[metaDataKey].sizes.forEach((s: Size) => {
5857
problemSizeResult[
59-
`${metaDataKey}'-'${getInstance(
60-
s.temporalResolution.toString(),
61-
s.spatialResolution.toString()
62-
)}`
58+
`${metaDataKey}'-'${s.name}`
6359
] = s.size
6460
})
6561
})
@@ -68,12 +64,8 @@ const actions = {
6864
results.rawBenchmarkResults.filter((benchmark: BenchmarkResult) =>
6965
(metaData[benchmark.benchmark] as MetaDataEntry)?.sizes?.find(
7066
(size) => {
71-
const temporalResolution =
72-
size.temporalResolution === "NA"
73-
? size.temporalResolution
74-
: `${size.temporalResolution}h`
7567
return (
76-
`${size.spatialResolution}-${temporalResolution}` ===
68+
size.name ===
7769
benchmark.size &&
7870
filters.problemSize.includes(
7971
problemSizeResult[

website-nextjs/src/types/meta-data.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11

22
type Size = {
3+
name: string
34
spatialResolution: number
45
temporalResolution: number | string
56
nOfConstraints: number

website-nextjs/src/utils/meta-data.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,8 @@ const getMetaData = async () => {
3535
return toCamelCase(rawData) as MetaData
3636
}
3737

38-
const getInstance = (temporalResolution: string, spatialResolution: string) => {
39-
const tempResolution =
40-
temporalResolution === "NA" ? temporalResolution : `${temporalResolution}h`
41-
return `${spatialResolution}-${tempResolution}`
42-
}
43-
4438
const getUniqueValues = <T, K extends keyof T>(data: T[], key: K): T[K][] =>
4539
Array.from(new Set(data.map(item => item[key])));
4640

4741

48-
export { getMetaData, getInstance, getUniqueValues }
42+
export { getMetaData, getUniqueValues }

0 commit comments

Comments
 (0)