Skip to content

Commit 1307ab1

Browse files
committed
Remove call to save recovery config during loading
- This solves the issue of a Neuropixels 2.0 probe causing up to four saves of the data into the same file, causing redundant writes
1 parent 4cce939 commit 1307ab1

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

Source/UI/NeuropixelsV2eProbeInterface.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -718,7 +718,7 @@ void NeuropixelsV2eProbeInterface::updateSettings()
718718
gainCorrectionFile->setText(npx->getGainCorrectionFile(probeIndex) == "None" ? "" : npx->getGainCorrectionFile(probeIndex), dontSendNotification);
719719
}
720720

721-
bool NeuropixelsV2eProbeInterface::applyProbeSettings(ProbeSettings<Neuropixels2e::numberOfChannels, Neuropixels2e::numberOfElectrodes>* p, bool shouldUpdateProbe)
721+
bool NeuropixelsV2eProbeInterface::applyProbeSettings(ProbeSettings<Neuropixels2e::numberOfChannels, Neuropixels2e::numberOfElectrodes>* p)
722722
{
723723
if (electrodeConfigurationComboBox != 0)
724724
electrodeConfigurationComboBox->setSelectedId(p->electrodeConfigurationIndex + 2, dontSendNotification);
@@ -749,11 +749,6 @@ bool NeuropixelsV2eProbeInterface::applyProbeSettings(ProbeSettings<Neuropixels2
749749
}
750750
}
751751

752-
if (shouldUpdateProbe)
753-
{
754-
CoreServices::saveRecoveryConfig();
755-
}
756-
757752
drawLegend();
758753
repaint();
759754

Source/UI/NeuropixelsV2eProbeInterface.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ namespace OnixSourcePlugin
5858

5959
void stopAcquisition() override;
6060

61-
bool applyProbeSettings(ProbeSettings<Neuropixels2e::numberOfChannels, Neuropixels2e::numberOfElectrodes>* p, bool shouldUpdateProbe = true);
61+
bool applyProbeSettings(ProbeSettings<Neuropixels2e::numberOfChannels, Neuropixels2e::numberOfElectrodes>* p);
6262

6363
void saveParameters(XmlElement* xml) override;
6464

0 commit comments

Comments
 (0)