Skip to content

Commit 4379009

Browse files
committed
Merge branch 'main' into issue-42
2 parents 4da3b2f + f26f14f commit 4379009

28 files changed

+456
-310
lines changed

Source/Devices/Bno055.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Bno055::Bno055(std::string name, std::string hubName, const oni_dev_idx_t device
2929
{
3030
auto streamIdentifier = getStreamIdentifier();
3131

32-
std::string port = getPortNameFromIndex(deviceIdx);
32+
std::string port = getPortName(deviceIdx);
3333
StreamInfo eulerAngleStream = StreamInfo(
3434
OnixDevice::createStreamName({ port, getHubName(), getName(), "Euler" }),
3535
"Bosch Bno055 9-axis inertial measurement unit (IMU) Euler angle",

Source/Devices/MemoryMonitor.cpp

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,33 @@ MemoryMonitorUsage::MemoryMonitorUsage(GenericProcessor* p)
2929
: LevelMonitor(p)
3030
{
3131
device = nullptr;
32+
setPassiveTooltip();
3233
}
3334

3435
void MemoryMonitorUsage::timerCallback()
3536
{
3637
if (device != nullptr)
3738
{
38-
setFillPercentage(std::log(device->getLastPercentUsedValue() + 1) / maxLogarithmicValue);
39+
auto memoryUsedPercent = device->getLastPercentUsedValue();
40+
auto logMemoryUsed = std::log(memoryUsedPercent + 1) / maxLogarithmicValue;
41+
setFillPercentage(logMemoryUsed);
42+
setTooltip(getNewTooltip(memoryUsedPercent));
3943
repaint();
4044
}
4145
}
4246

47+
std::string MemoryMonitorUsage::getNewTooltip(float memoryUsage)
48+
{
49+
std::stringstream ss;
50+
ss << "Memory Used: " << std::setprecision(3) << memoryUsage << "%";
51+
return ss.str();
52+
}
53+
54+
void MemoryMonitorUsage::setPassiveTooltip()
55+
{
56+
setTooltip("Monitors the percent of the hardware memory buffer used.");
57+
}
58+
4359
void MemoryMonitorUsage::setMemoryMonitor(std::shared_ptr<MemoryMonitor> memoryMonitor)
4460
{
4561
device = memoryMonitor;
@@ -54,6 +70,7 @@ void MemoryMonitorUsage::stopAcquisition()
5470
{
5571
stopTimer();
5672
setFillPercentage(0.0f);
73+
setPassiveTooltip();
5774
repaint();
5875
}
5976

Source/Devices/MemoryMonitor.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,10 @@ namespace OnixSourcePlugin
108108
void timerCallback() override;
109109

110110
void setMemoryMonitor(std::shared_ptr<MemoryMonitor> memoryMonitor);
111-
112111
void startAcquisition();
113-
114112
void stopAcquisition();
113+
void setPassiveTooltip();
114+
static std::string getNewTooltip(float memoryUsage);
115115

116116
private:
117117

Source/Devices/Neuropixels1e.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ void NeuropixelsV1eBackgroundUpdater::run()
7979
Neuropixels1e::Neuropixels1e(std::string name, std::string hubName, const oni_dev_idx_t deviceIdx_, std::shared_ptr<Onix1> ctx_) :
8080
Neuropixels1(name, hubName, OnixDeviceType::NEUROPIXELSV1E, deviceIdx_, ctx_)
8181
{
82-
std::string port = getPortNameFromIndex(getDeviceIdx());
82+
std::string port = getPortName(getDeviceIdx());
8383
StreamInfo apStream = StreamInfo(
8484
OnixDevice::createStreamName({ port, getHubName(), getName(), STREAM_NAME_AP }),
8585
"Neuropixels 1.0 AP band data stream",

Source/Devices/Neuropixels1f.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ void NeuropixelsV1fBackgroundUpdater::run()
6666
Neuropixels1f::Neuropixels1f(std::string name, std::string hubName, const oni_dev_idx_t deviceIdx_, std::shared_ptr<Onix1> ctx_) :
6767
Neuropixels1(name, hubName, OnixDeviceType::NEUROPIXELSV1F, deviceIdx_, ctx_)
6868
{
69-
std::string port = getPortNameFromIndex(deviceIdx);
69+
std::string port = getPortName(deviceIdx);
7070
StreamInfo apStream = StreamInfo(
7171
OnixDevice::createStreamName({ port, getHubName(), getName(), STREAM_NAME_AP }),
7272
"Neuropixels 1.0 AP band data stream",

Source/Devices/Neuropixels2e.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Neuropixels2e::Neuropixels2e(std::string name, std::string hubName, const oni_de
4343
void Neuropixels2e::createDataStream(int n)
4444
{
4545
StreamInfo apStream = StreamInfo(
46-
OnixDevice::createStreamName({ getPortNameFromIndex(getDeviceIdx()), getHubName(), "Probe" + std::to_string(n) }),
46+
OnixDevice::createStreamName({ getPortName(getDeviceIdx()), getHubName(), "Probe" + std::to_string(n) }),
4747
"Neuropixels 2.0 data stream",
4848
getStreamIdentifier(),
4949
numberOfChannels,

Source/Devices/PolledBno055.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ PolledBno055::PolledBno055(std::string name, std::string hubName, const oni_dev_
3131
{
3232
auto streamIdentifier = getStreamIdentifier();
3333

34-
std::string port = getPortNameFromIndex(deviceIdx);
34+
std::string port = getPortName(deviceIdx);
3535
StreamInfo eulerAngleStream = StreamInfo(
3636
OnixDevice::createStreamName({ port, getHubName(), getName(), "Euler" }),
3737
"Bosch Bno055 9-axis inertial measurement unit (IMU) Euler angle",

Source/NeuropixelsComponents.h

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,23 @@ namespace OnixSourcePlugin
5656
K = 10,
5757
L = 11,
5858
M = 12,
59+
A1 = 13, // used for quad base
60+
A2 = 14,
61+
A3 = 15,
62+
A4 = 16,
63+
B1 = 17,
64+
B2 = 18,
65+
B3 = 19,
66+
B4 = 20,
67+
C1 = 21,
68+
C2 = 22,
69+
C3 = 23,
70+
C4 = 24,
71+
D1 = 25,
72+
D2 = 26,
73+
D3 = 27,
74+
D4 = 28,
75+
OFF = 255 //used in v1 API
5976
};
6077

6178
enum class ElectrodeStatus

Source/Onix1.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ std::map<int, int> Onix1::getHubIds(device_map_t deviceTable) const
8787

8888
auto deviceIndices = getDeviceIndices(deviceTable);
8989

90-
auto offsets = OnixDevice::getUniqueOffsetsFromIndices(deviceIndices, false);
90+
auto offsets = OnixDevice::getUniqueOffsets(deviceIndices, false);
9191

9292
for (int i = 0; i < offsets.size(); i++)
9393
{
@@ -111,7 +111,7 @@ std::vector<int> Onix1::getDeviceIndices(device_map_t deviceMap, int hubIndex)
111111

112112
for (const auto& [idx, dev] : deviceMap)
113113
{
114-
if (dev.id != ONIX_NULL && (hubIndex == -1 || OnixDevice::getOffsetFromIndex(dev.idx) == hubIndex))
114+
if (dev.id != ONIX_NULL && (hubIndex == -1 || OnixDevice::getOffset(dev.idx) == hubIndex))
115115
deviceIndices.emplace_back(idx);
116116
}
117117

Source/OnixDevice.cpp

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -173,28 +173,28 @@ std::string OnixDevice::getPortName(PortName port)
173173
return getPortName(getPortOffset(port));
174174
}
175175

176-
std::string OnixDevice::getPortNameFromIndex(oni_dev_idx_t index)
176+
std::string OnixDevice::getPortName(oni_dev_idx_t index)
177177
{
178-
return getPortName(getOffsetFromIndex(index));
178+
return getPortName(getOffset(index));
179179
}
180180

181181
PortName OnixDevice::getPortFromIndex(oni_dev_idx_t index)
182182
{
183183
return index & (1 << 8) ? PortName::PortA : PortName::PortB;
184184
}
185185

186-
int OnixDevice::getOffsetFromIndex(oni_dev_idx_t index)
186+
int OnixDevice::getOffset(oni_dev_idx_t index)
187187
{
188188
return index & 0x0000FF00;
189189
}
190190

191-
std::vector<int> OnixDevice::getUniqueOffsetsFromIndices(std::vector<int> indices, bool ignoreBreakoutBoard)
191+
std::vector<int> OnixDevice::getUniqueOffsets(std::vector<int> indices, bool ignoreBreakoutBoard)
192192
{
193193
std::set<int> offsets;
194194

195195
for (auto index : indices)
196196
{
197-
auto offset = getOffsetFromIndex(index);
197+
auto offset = getOffset(index);
198198

199199
if (offset == HubAddressBreakoutBoard && ignoreBreakoutBoard) continue;
200200

@@ -204,7 +204,19 @@ std::vector<int> OnixDevice::getUniqueOffsetsFromIndices(std::vector<int> indice
204204
return std::vector<int>(offsets.begin(), offsets.end());
205205
}
206206

207-
Array<PortName> OnixDevice::getUniquePortsFromIndices(std::vector<int> indices)
207+
std::vector<int> OnixDevice::getUniqueOffsets(OnixDeviceMap devices, bool ignoreBreakoutBoard)
208+
{
209+
std::vector<int> indices;
210+
211+
for (const auto& [key, _] : devices)
212+
{
213+
indices.emplace_back(key);
214+
}
215+
216+
return getUniqueOffsets(indices, ignoreBreakoutBoard);
217+
}
218+
219+
Array<PortName> OnixDevice::getUniquePorts(std::vector<int> indices)
208220
{
209221
Array<PortName> ports;
210222

0 commit comments

Comments
 (0)