Address review comments

- Change some log statements to console instead of debug so users can get real-time feedback
- Point all NPX searches to a single constant value for consistency

Author: bparks13

Source/OnixSource.cpp

@@ -284,7 +284,7 @@ bool OnixSource::checkHubFirmwareCompatibility(std::shared_ptr<Onix1> context, d
 			auto majorVersion = (firmwareVersion & 0xFF00) >> 8;
 			auto minorVersion = firmwareVersion & 0xFF;
 
-			LOGD("Breakout board firmware version: v", majorVersion, ".", minorVersion);
+			LOGC("Breakout board firmware version: v", majorVersion, ".", minorVersion);
 
 			if (majorVersion != RequiredMajorVersion)
 			{
@@ -409,7 +409,7 @@ bool OnixSource::initializeDevices(device_map_t deviceTable, bool updateStreamIn
 
 			auto EEPROM = std::make_unique<HeadStageEEPROM>(index, context);
 			uint32_t hsid = EEPROM->GetHeadStageID();
-			LOGD("Detected headstage ", onix_hub_str(hsid));
+			LOGC("Detected headstage ", onix_hub_str(hsid));
 
 			if (hsid == ONIX_HUB_HSNP2E)
 			{

Source/UI/NeuropixelsV1Interface.cpp

@@ -900,9 +900,7 @@ std::string NeuropixelsV1Interface::searchDirectoryForCalibrationFile(std::strin
 		return "";
 	}
 
-	static constexpr int recursiveLevels = 1;
-
-	auto calibrationFiles = SettingsInterface::searchDirectoryForFile(rootDirectory, filename, recursiveLevels);
+	auto calibrationFiles = searchDirectoryForFile(rootDirectory, filename, SettingsInterface::NeuropixelsCalibrationFileRecursiveLevels);
 
 	if (calibrationFiles.size() != 1)
 	{
@@ -911,7 +909,7 @@ std::string NeuropixelsV1Interface::searchDirectoryForCalibrationFile(std::strin
 
 		if (calibrationFiles.size() > 1)
 		{
-			msg += " Check logs for all files discovered.";
+			msg += " Check console for all files discovered.";
 		}
 
 		Onix1::showWarningMessageBoxAsync("Wrong Number of Calibration Files", msg);

Source/UI/NeuropixelsV2eProbeInterface.cpp

@@ -573,9 +573,8 @@ std::string NeuropixelsV2eProbeInterface::searchDirectoryForCalibrationFile(std:
 	}
 
 	std::string filename = std::to_string(sn) + GainCalibrationFilename;
-	static constexpr int recursiveLevels = 1;
 
-	auto calibrationFiles = SettingsInterface::searchDirectoryForFile(rootDirectory, filename, recursiveLevels);
+	auto calibrationFiles = searchDirectoryForFile(rootDirectory, filename, SettingsInterface::NeuropixelsCalibrationFileRecursiveLevels);
 
 	if (calibrationFiles.size() != 1)
 	{

Source/UI/SettingsInterface.h

@@ -151,6 +151,8 @@ namespace OnixSourcePlugin
 			return rootElement.release();
 		}
 
+    static constexpr int NeuropixelsCalibrationFileRecursiveLevels = 2;
+
 		// Given a File object defining the path to a directory, a filename to search for, and (optionally) the number of recursive levels to
 		// iterate through, return a list of all files that match the given filename in the directory (or directories for recursive searches)
 		static std::vector<File> searchDirectoryForFile(File directory, std::string filename, int recursiveLevels = 0)
@@ -174,7 +176,7 @@ namespace OnixSourcePlugin
 			for (DirectoryEntry entry : RangedDirectoryIterator(directory, false, filename, File::findFiles, File::FollowSymlinks::no))
 			{
 				matchingFiles.emplace_back(entry.getFile());
-				LOGD("Discovered file: ", entry.getFile().getFullPathName());
+				LOGC("Discovered file: ", entry.getFile().getFullPathName());
 			}
 
 			return matchingFiles;