Code simplification and remove unessesary state

- Use tuple return value instead of multiple out parameters
- Remove unnessary state in ContextTask

Author: jonnew

OpenEphys.Onix1/ContextTask.cs

@@ -76,8 +76,6 @@ public class ContextTask : IDisposable
         readonly string contextDriver = DefaultDriver;
         readonly int contextIndex = DefaultIndex;
 
-        private oni.Hub controllerHub;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="ContextTask"/> class.
         /// </summary>
@@ -96,13 +94,11 @@ internal ContextTask(string driver, int index)
             contextIndex = index;
             ctx = new oni.Context(contextDriver, contextIndex);
             Initialize();
-            controllerHub = GetHub(0);
-            uint versionMajor;
-            GenericHelper.GetVersionComponents(controllerHub.FirmwareVersion, out versionMajor, out _);
-            if (versionMajor != 2)
+            var (major, _) = GenericHelper.GetFirmwareVersionComponents(GetHub(0).FirmwareVersion);
+            if (major != 2)
             {
-                throw new NotSupportedException("This library requires version 2.x of the ONIX firmware."
-                    + "Please update it. Instructions can be found in "
+                throw new NotSupportedException("This library requires version 2.x of the ONIX firmware. "
+                    + "Please perform a firmware update to use this library. Instructions can be found at "
                     + "https://open-ephys.github.io/onix-docs/Hardware%20Guide/PCIe%20Host/updating-firmware.html");
             }
         }

OpenEphys.Onix1/GenericHelper.cs

@@ -8,15 +8,13 @@ public static uint GetHubAddressFromDeviceAddress(uint deviceAddress)
         }
 
         /// <summary>
-        /// Gets the version components from a 16-bit version register value
+        /// Gets 8-bit version components from a 16-bit version register value
         /// </summary>
-        /// <param name="rawVersion">Raw 16-bit version</param>
-        /// <param name="major">Contains the major component extracted from <paramref name="rawVersion"/></param>
-        /// <param name="minor">Contains the minor component extracted from <paramref name="rawVersion"/></param>
-        public static void GetVersionComponents(uint rawVersion, out uint major, out uint minor)
+        /// <param name="version">Register value containing a 16-bit firmware version number.</param>
+        /// <returns> A tuple containing the 8-bit major and minor version components.</returns>
+        internal static (byte major, byte minor) GetFirmwareVersionComponents(uint version)
         {
-            major = (rawVersion >> 8) & 0xFF;
-            minor = rawVersion & 0xFF;
+            return ((byte)((version >> 8) & 0xFF), (byte)(version & 0xFF));
         }
     }
 }