Minor emmendments

- Instead of showing first JSON parse error, print all of them to stderr
- Realized that static functions in the NeuropixelsV1Helper.cs should
  really accept a path instead of a StreamReader as their first
  arguement because StreamReader is to general because cal data is always
  provided in a file and this function call expects to start from the
  beginning of the stream. This will require a change in the public API.
  I will open a new issue about this.

Author: jonnew

OpenEphys.Onix1.Design/DesignHelper.cs

@@ -33,8 +33,14 @@ static class DesignHelper
 
             if (errors.Count > 0)
             {
-                MessageBox.Show($"Warning: There were {errors.Count} errors found while deserializing the JSON string.\n" +
-                    $"The first error was '{errors.First()}'.", "Deserializer Error");
+                MessageBox.Show($"There were errors encountered while parsing a JSON string. Check the console " +
+                    $"for an error log.", "JSON Parse Error");
+
+                foreach (var e in errors)
+                {
+                    Console.Error.WriteLine(e);
+                }
+
                 return default;
             }
 

OpenEphys.Onix1/NeuropixelsV1Helper.cs

@@ -20,14 +20,24 @@ public static class NeuropixelsV1Helper
         /// <exception cref="InvalidOperationException"></exception>
         public static NeuropixelsV1eAdcCalibration ParseAdcCalibrationFile(StreamReader file)
         {
+            // TODO: "file" input argument should either be a FileStream or a path string. StreamReader is to
+            // general because cal data is always provided in a file and this function call expects to start
+            // from the beginning of the stream. This will require a change in the public API.
+
             if (file == null || file.EndOfStream)
             {
                 throw new ArgumentException("Incoming stream reader is not pointing to a valid ADC calibration file.");
             }
 
-            var adcSerialNumber = ulong.Parse(file.ReadLine());
+            string path = (file.BaseStream as FileStream)?.Name;
+
+            if (!ulong.TryParse(file.ReadLine(), out ulong adcSerialNumber))
+            {
+                throw new ArgumentException($"The calibration file {path} specified is " +
+                    $"incorrectly formatted.");
+            }
 
-            NeuropixelsV1eAdc[] adcs = new NeuropixelsV1eAdc[NeuropixelsV1e.AdcCount];
+            var adcs = new NeuropixelsV1eAdc[NeuropixelsV1e.AdcCount];
 
             for (var i = 0; i < NeuropixelsV1e.AdcCount; i++)
             {
@@ -64,12 +74,22 @@ public static NeuropixelsV1eAdcCalibration ParseAdcCalibrationFile(StreamReader
         /// <exception cref="InvalidOperationException"></exception>
         public static NeuropixelsV1eGainCorrection ParseGainCalibrationFile(StreamReader file, NeuropixelsV1Gain apGain, NeuropixelsV1Gain lfpGain)
         {
+            // TODO: "file" input argument should either be a FileStream or a path string. StreamReader is to
+            // general because cal data is always provided in a file and this function call expects to start
+            // from the beginning of the stream. This will require a change in the public API.
+
             if (file == null || file.EndOfStream)
             {
                 throw new ArgumentException("Incoming stream reader is not pointing to a valid gain calibration file.");
             }
 
-            var serialNumber = ulong.Parse(file.ReadLine());
+            string path = (file.BaseStream as FileStream)?.Name;
+
+            if (!ulong.TryParse(file.ReadLine(), out ulong serialNumber))
+            {
+                throw new ArgumentException($"The calibration file {path} specified is " +
+                    $"incorrectly formatted.");
+            }
 
             var gainCorrections = file.ReadLine().Split(',').Skip(1);
 

OpenEphys.Onix1/NeuropixelsV1eRegisterContext.cs

@@ -38,21 +38,19 @@ public NeuropixelsV1eRegisterContext(DeviceContext deviceContext, uint i2cAddres
                     $"{probeSerialNumber}");
             }
 
-            StreamReader adcFile = new(adcCalibrationFile);
-
             // parse ADC calibration file
-            var adcCalibration = NeuropixelsV1Helper.ParseAdcCalibrationFile(adcFile);
+            var adcCalibration = NeuropixelsV1Helper.ParseAdcCalibrationFile(new StreamReader(adcCalibrationFile)); 
 
             if (adcCalibration.SN != probeSerialNumber)
             {
                 throw new ArgumentException($"The probe serial number ({probeSerialNumber}) does not " +
                     $"match the ADC calibration file serial number: {adcCalibration.SN}.");
             }
 
-            StreamReader gainFile = new(gainCalibrationFile);
-
+            
             // parse gain correction file
-            var gainCorrection = NeuropixelsV1Helper.ParseGainCalibrationFile(gainFile, probeConfiguration.SpikeAmplifierGain, probeConfiguration.LfpAmplifierGain);
+            var gainCorrection = NeuropixelsV1Helper.ParseGainCalibrationFile(new StreamReader(gainCalibrationFile), 
+                probeConfiguration.SpikeAmplifierGain, probeConfiguration.LfpAmplifierGain);
 
             if (gainCorrection.SN != probeSerialNumber)
             {

OpenEphys.Onix1/NeuropixelsV2.cs

@@ -35,7 +35,6 @@ static class NeuropixelsV2
         public const int DummyRegisterCount = 4;
         public const int RegistersPerShank = ElectrodePerShank + ReferencePixelCount + DummyRegisterCount;
 
-
         internal static BitArray[] GenerateShankBits(NeuropixelsV2QuadShankProbeConfiguration probe)
         {
             BitArray[] shankBits =
@@ -124,7 +123,11 @@ internal static double ReadGainCorrection(string gainCalibrationFile, ulong prob
             }
 
             var gainFile = new StreamReader(gainCalibrationFile);
-            var sn = ulong.Parse(gainFile.ReadLine());
+            if(!ulong.TryParse(gainFile.ReadLine(), out ulong sn))
+            {
+                throw new ArgumentException($"The calibration file {gainCalibrationFile} specified for {probe} is " +
+                    $"incorrectly formatted.");
+            }
 
             if (probeSerialNumber != sn)
             {