Move scale to second pane

- Only applies for dialogs that need to draw a scale (such as NeuropixelsV1e/V1f and NeuropixelsV2e/V2eBeta)
- Updated the logic for constraining pan/zoom in all dialogs so that the probe is always in view
- Standardized dialog sizes for consistency

Author: bparks13

OpenEphys.Onix1.Design/ChannelConfigurationDialog.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Drawing;
 using System.Linq;
 using System.Windows.Forms;
 using OpenEphys.ProbeInterface.NET;
@@ -40,8 +39,8 @@ public NeuropixelsV1ChannelConfigurationDialog(NeuropixelsV1ProbeConfiguration p
 
             ProbeConfiguration = probeConfiguration;
 
-            ZoomInBoundaryX = 400;
-            ZoomInBoundaryY = 400;
+            ZoomInBoundaryX = 200;
+            ZoomInBoundaryY = 200;
 
             HighlightEnabledContacts();
             UpdateContactLabels();
@@ -87,7 +86,6 @@ internal override void ZoomEvent(ZedGraphControl sender, ZoomState oldState, Zoo
             base.ZoomEvent(sender, oldState, newState);
 
             UpdateFontSize();
-            DrawScale();
             RefreshZedGraph();
 
             OnZoomHandler();
@@ -98,90 +96,21 @@ private void OnZoomHandler()
             OnZoom?.Invoke(this, EventArgs.Empty);
         }
 
+        internal override bool IsDrawScale() => true;
+
         internal override void DrawScale()
         {
-            if (ProbeConfiguration == null)
+            if (ProbeConfiguration == null || zedGraphChannels.MasterPane.PaneList.Count < 2)
                 return;
 
-            const string ScalePointsTag = "scale_points";
-            const string ScaleTextTag = "scale_text";
-
-            zedGraphChannels.GraphPane.GraphObjList.RemoveAll(obj => obj is TextObj && obj.Tag is string tag && tag == ScaleTextTag);
-            zedGraphChannels.GraphPane.CurveList.RemoveAll(curve => curve.Tag is string tag && tag == ScalePointsTag);
-
-            const int MajorTickIncrement = 100;
-            const int MajorTickLength = 10;
-            const int MinorTickIncrement = 10;
-            const int MinorTickLength = 5;
-
-            if (ProbeConfiguration.ProbeGroup.Probes.ElementAt(0).SiUnits != ProbeSiUnits.um)
-            {
-                MessageBox.Show("Warning: Expected ProbeGroup units to be in microns, but it is in millimeters. Scale might not be accurate.");
-            }
-
-            var fontSize = CalculateFontSize();
-
-            var zoomedOut = fontSize <= 2;
-
-            fontSize = zoomedOut ? 6 : fontSize * 3;
-            var majorTickOffset = MajorTickLength + CalculateScaleRange(zedGraphChannels.GraphPane.XAxis.Scale) * 0.015;
-            majorTickOffset = majorTickOffset > 50 ? 50 : majorTickOffset;
-
-            var x = GetProbeRight(zedGraphChannels.GraphPane.GraphObjList) + 40;
-            var minY = GetProbeBottom(zedGraphChannels.GraphPane.GraphObjList);
-            var maxY = GetProbeTop(zedGraphChannels.GraphPane.GraphObjList);
-
-            int textPosition = 0;
-
-            PointPairList pointList = new();
-
-            var countMajorTicks = 0;
-
-            for (int i = (int)minY; i < maxY; i += MajorTickIncrement)
-            {
-                PointPair majorTickLocation = new(x + MajorTickLength, minY + MajorTickIncrement * countMajorTicks);
-
-                pointList.Add(new PointPair(x, minY + MajorTickIncrement * countMajorTicks));
-                pointList.Add(majorTickLocation);
-                pointList.Add(new PointPair(x, minY + MajorTickIncrement * countMajorTicks));
-
-                if (!zoomedOut || countMajorTicks % 5 == 0)
-                {
-                    TextObj textObj = new($"{textPosition} µm", majorTickLocation.X + 10, majorTickLocation.Y, CoordType.AxisXYScale, AlignH.Left, AlignV.Center)
-                    {
-                        Tag = ScaleTextTag
-                    };
-                    textObj.FontSpec.Border.IsVisible = false;
-                    textObj.FontSpec.Size = fontSize;
-                    zedGraphChannels.GraphPane.GraphObjList.Add(textObj);
-
-                    textPosition += zoomedOut ? 5 * MajorTickIncrement : MajorTickIncrement;
-                }
-
-                if (!zoomedOut)
-                {
-                    var countMinorTicks = 1;
-
-                    for (int j = i + MinorTickIncrement; j < i + MajorTickIncrement && i + MinorTickIncrement * countMinorTicks < maxY; j += MinorTickIncrement)
-                    {
-                        pointList.Add(new PointPair(x, minY + MajorTickIncrement * countMajorTicks + MinorTickIncrement * countMinorTicks));
-                        pointList.Add(new PointPair(x + MinorTickLength, minY + MajorTickIncrement * countMajorTicks + MinorTickIncrement * countMinorTicks));
-                        pointList.Add(new PointPair(x, minY + MajorTickIncrement * countMajorTicks + MinorTickIncrement * countMinorTicks));
-
-                        countMinorTicks++;
-                    }
-                }
-
-                countMajorTicks++;
-            }
-
-            var curve = zedGraphChannels.GraphPane.AddCurve(ScalePointsTag, pointList, Color.Black, SymbolType.None);
+            var pane = zedGraphChannels.MasterPane.PaneList[1];
 
-            const float scaleBarWidth = 1;
+            pane.YAxis.Scale.Min = GetProbeBottom(zedGraphChannels.GraphPane.GraphObjList);
+            pane.YAxis.Scale.Max = GetProbeTop(zedGraphChannels.GraphPane.GraphObjList);
 
-            curve.Line.Width = scaleBarWidth;
-            curve.Label.IsVisible = false;
-            curve.Symbol.IsVisible = false;
+            pane.YAxis.Scale.Format = "#####0' " + ProbeGroup.Probes.First().SiUnits.ToString() + "'";
+            pane.YAxis.Scale.Mag = 0;
+            pane.YAxis.Scale.MagAuto = false;
         }
 
         internal override void HighlightEnabledContacts()

OpenEphys.Onix1.Design/NeuropixelsV1ChannelConfigurationDialog.cs

@@ -115,7 +115,6 @@ private void FormShown(object sender, EventArgs e)
             }
 
             ChannelConfiguration.Show();
-            ChannelConfiguration.ConnectResizeEventHandler();
             ChannelConfiguration.OnResizeZedGraph += ResizeTrackBar;
         }
 
@@ -317,22 +316,22 @@ private void CheckStatus()
 
             panelProbe.Visible = adcCalibration.HasValue && gainCorrection.HasValue;
 
-            if (toolStripAdcCalSN.Text == NoFileSelected) 
+            if (toolStripAdcCalSN.Text == NoFileSelected)
                 toolStripLabelAdcCalibrationSN.Image = Properties.Resources.StatusWarningImage;
-            else if (toolStripAdcCalSN.Text == InvalidFile) 
+            else if (toolStripAdcCalSN.Text == InvalidFile)
                 toolStripLabelAdcCalibrationSN.Image = Properties.Resources.StatusCriticalImage;
             else if (toolStripGainCalSN.Text != NoFileSelected && toolStripGainCalSN.Text != InvalidFile && toolStripAdcCalSN.Text != toolStripGainCalSN.Text)
                 toolStripLabelAdcCalibrationSN.Image = Properties.Resources.StatusBlockedImage;
-            else 
+            else
                 toolStripLabelAdcCalibrationSN.Image = Properties.Resources.StatusReadyImage;
 
-            if (toolStripGainCalSN.Text == NoFileSelected) 
+            if (toolStripGainCalSN.Text == NoFileSelected)
                 toolStripLabelGainCalibrationSn.Image = Properties.Resources.StatusWarningImage;
-            else if (toolStripGainCalSN.Text == InvalidFile) 
+            else if (toolStripGainCalSN.Text == InvalidFile)
                 toolStripLabelGainCalibrationSn.Image = Properties.Resources.StatusCriticalImage;
             else if (toolStripAdcCalSN.Text != NoFileSelected && toolStripAdcCalSN.Text != InvalidFile && toolStripAdcCalSN.Text != toolStripGainCalSN.Text)
                 toolStripLabelGainCalibrationSn.Image = Properties.Resources.StatusBlockedImage;
-            else 
+            else
                 toolStripLabelGainCalibrationSn.Image = Properties.Resources.StatusReadyImage;
         }
 
@@ -455,7 +454,6 @@ private void ResetZoom()
         {
             ChannelConfiguration.ResetZoom();
             ChannelConfiguration.RefreshZedGraph();
-            ChannelConfiguration.DrawScale();
         }
 
         private void MoveToVerticalPosition(float relativePosition)