Merge pull request #451 from open-ephys/issue-449

jonnew · web-flow · commit d82c33b5729e · 2025-05-29T15:58:59.000-04:00
Change DigitalPortState backing type from ushort to byte
diff --git a/OpenEphys.Onix1/ConfigureDigitalIO.cs b/OpenEphys.Onix1/ConfigureDigitalIO.cs
@@ -84,7 +84,7 @@ public NameConverter()
     /// Specifies the state of the ONIX breakout board's digital input pins.
     /// </summary>
     [Flags]
-    public enum DigitalPortState : ushort
+    public enum DigitalPortState : byte
     {
         /// <summary>
         /// Specifies that pin 0 is high.
diff --git a/OpenEphys.Onix1/DigitalInputDataFrame.cs b/OpenEphys.Onix1/DigitalInputDataFrame.cs
@@ -36,6 +36,7 @@ struct DigitalInputPayload
     {
         public ulong HubClock;
         public DigitalPortState DigitalInputs;
+        public byte Pad; // NB: Pad comes after port state due to endianness change
         public BreakoutButtonState Buttons;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ public NameConverter()`
`84`	`84`	`/// Specifies the state of the ONIX breakout board's digital input pins.`
`85`	`85`	`/// </summary>`
`86`	`86`	`[Flags]`
`87`		`- public enum DigitalPortState : ushort`
	`87`	`+ public enum DigitalPortState : byte`
`88`	`88`	`{`
`89`	`89`	`/// <summary>`
`90`	`90`	`/// Specifies that pin 0 is high.`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@ struct DigitalInputPayload`
`36`	`36`	`{`
`37`	`37`	`public ulong HubClock;`
`38`	`38`	`public DigitalPortState DigitalInputs;`
	`39`	`+ public byte Pad; // NB: Pad comes after port state due to endianness change`
`39`	`40`	`public BreakoutButtonState Buttons;`
`40`	`41`	`}`
`41`	`42`	`}`