Allow applied voltage to be persistent after workflow stops

bparks13 · bparks13 · commit db9bbb6a8a9f · 2025-05-21T14:59:46.000-04:00
diff --git a/OpenEphys.Onix1/ConfigureNeuropixelsV2ePortController.cs b/OpenEphys.Onix1/ConfigureNeuropixelsV2ePortController.cs
@@ -27,7 +27,6 @@ protected override bool ConfigurePortVoltage(DeviceContext device, out double vo
             return false;
         }
 
-
         void SetVoltage(DeviceContext device, double voltage)
         {
             device.WriteRegister(PortController.PORTVOLTAGE, 0);
diff --git a/OpenEphys.Onix1/ConfigurePortController.cs b/OpenEphys.Onix1/ConfigurePortController.cs
@@ -59,7 +59,7 @@ public override IObservable<ContextTask> Process(IObservable<ContextTask> source
             .ConfigureLink(context =>
             {
                 var device = context.GetDeviceContext(deviceAddress, DeviceType);
-                void dispose() { device.WriteRegister(PortController.PORTVOLTAGE, 0); PortVoltage.Applied = null; }
+                void dispose() { device.WriteRegister(PortController.PORTVOLTAGE, 0); }
                 device.WriteRegister(PortController.ENABLE, 1);
 
                 bool serdesLock = false;

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,6 @@ protected override bool ConfigurePortVoltage(DeviceContext device, out double vo`
`27`	`27`	`return false;`
`28`	`28`	`}`
`29`	`29`
`30`		`-`
`31`	`30`	`void SetVoltage(DeviceContext device, double voltage)`
`32`	`31`	`{`
`33`	`32`	`device.WriteRegister(PortController.PORTVOLTAGE, 0);`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public override IObservable<ContextTask> Process(IObservable<ContextTask> source`
`59`	`59`	`.ConfigureLink(context =>`
`60`	`60`	`{`
`61`	`61`	`var device = context.GetDeviceContext(deviceAddress, DeviceType);`
`62`		`- void dispose() { device.WriteRegister(PortController.PORTVOLTAGE, 0); PortVoltage.Applied = null; }`
	`62`	`+ void dispose() { device.WriteRegister(PortController.PORTVOLTAGE, 0); }`
`63`	`63`	`device.WriteRegister(PortController.ENABLE, 1);`
`64`	`64`
`65`	`65`	`bool serdesLock = false;`