Merge pull request #480 from open-ephys/issue-479

jonnew · web-flow · commit e24f6dbf94eb · 2025-08-18T10:53:59.000-04:00
Account for two tick delay in sample counter on DigitalIO device
diff --git a/OpenEphys.Onix1/ConfigureDigitalIO.cs b/OpenEphys.Onix1/ConfigureDigitalIO.cs
@@ -116,7 +116,7 @@ public override IObservable<ContextTask> Process(IObservable<ContextTask> source
 
                 if (sr is not null)
                 {
-                    var periodTicks = (uint)(baseFreqHz / sr);
+                    var periodTicks = (uint)(baseFreqHz / sr) - 2; // NB: -2 results from known issue in version 2 of DigitalIO device
                     device.WriteRegister(DigitalIO.SAMPLE_PERIOD, periodTicks);
                 } else
                 {

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ public override IObservable<ContextTask> Process(IObservable<ContextTask> source`
`116`	`116`
`117`	`117`	`if (sr is not null)`
`118`	`118`	`{`
`119`		`- var periodTicks = (uint)(baseFreqHz / sr);`
	`119`	`+ var periodTicks = (uint)(baseFreqHz / sr) - 2; // NB: -2 results from known issue in version 2 of DigitalIO device`
`120`	`120`	`device.WriteRegister(DigitalIO.SAMPLE_PERIOD, periodTicks);`
`121`	`121`	`} else`
`122`	`122`	`{`