Skip to content

Commit f6f3100

Browse files
committed
Address review comments
1 parent 6dbe5b8 commit f6f3100

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<PackageLicenseFile>LICENSE</PackageLicenseFile>
1414
<UseArtifactsOutput>true</UseArtifactsOutput>
1515
<PackageIcon>icon.png</PackageIcon>
16-
<VersionPrefix>0.6.1</VersionPrefix>
16+
<VersionPrefix>0.7.0</VersionPrefix>
1717
<VersionSuffix></VersionSuffix>
1818
<LangVersion>10.0</LangVersion>
1919
<Features>strict</Features>

OpenEphys.Onix1/ConfigureLoadTester.cs

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public ConfigureLoadTester()
5050
/// </summary>
5151
/// <remarks>
5252
/// These data are produced by the host and are used to impose a load on host to controller
53-
/// commutation. They are discarded by the controller when they are received.
53+
/// communication. They are discarded by the controller when they are received.
5454
/// </remarks>
5555
[Category(ConfigurationCategory)]
5656
[Description("Number of repetitions of the 32-bit integer dummy words sent with each write frame.")]
@@ -124,18 +124,11 @@ static class LoadTester
124124
public const int ID = 27;
125125

126126
public const uint ENABLE = 0;
127-
public const uint CLK_DIV = 1; // Heartbeat clock divider ratio. Default results in 10 Hz heartbeat.
128-
// Values less than CLK_HZ / 10e6 Hz will result in 1kHz.
129-
public const uint CLK_HZ = 2; // The frequency parameter, CLK_HZ, used in the calculation of CLK_DIV
130-
public const uint DT0H16_WORDS = 3; // Number of repetitions of 16-bit unsigned integer 42 sent with each frame.
131-
// Note: max here depends of CLK_HZ and CLK_DIV. There needs to be enough clock
132-
// cycles to push the data at the requested CLK_HZ. Specifically,
133-
// CLK_HZ / CLK_DIV >= DT0H16_WORDS + 9. Going above this will result in
134-
// decreased bandwidth as samples will be skipped.
135-
public const uint HTOD32_WORDS = 4; // Number of 32-bit words in a write-frame. All write frame data is ignored except
136-
// the first 64-bits, which are looped back into the device to host data frame for
137-
// testing loop latency. This value must be at least 2.
138-
127+
public const uint CLK_DIV = 1;
128+
public const uint CLK_HZ = 2;
129+
public const uint DT0H16_WORDS = 3;
130+
public const uint HTOD32_WORDS = 4;
131+
public const uint DTOH_START = 5;
139132

140133
internal class NameConverter : DeviceNameConverter
141134
{

0 commit comments

Comments
 (0)