Skip to content

Commit ffb42be

Browse files
authored
Merge pull request #466 from open-ephys/issue-460
Rename OutputClockData as OutputClockHardwareParameters
2 parents dacf31e + 29d127f commit ffb42be

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

OpenEphys.Onix1/Bno055DataFrame.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace OpenEphys.Onix1
1414
/// href="https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bno055-ds000.pdf">datasheet</a>)
1515
/// . If the chip is in NDOF mode and is calibrated, orientation measurements (Quaternion, Euler Angles,
1616
/// and Gravity Vector) are absolute ("allocentric") and referenced to the gravity vector and Earth's
17-
/// magnetic field. Specifically, if the chip's axes are oriented such that Y points towords magnetic
17+
/// magnetic field. Specifically, if the chip's axes are oriented such that Y points towards magnetic
1818
/// north, X points towards magnetic east, and Z points opposite the gravity vector, the orientation
1919
/// reading will be null (i.e. Quaternion: X = 0, Y = 0, Z = 0, W = 1; Euler Angles: Yaw = 0, Pitch = 0,
2020
/// and Roll = 0 degrees; Gravity: X = 0, Y = 0, Z = 9.8 m/s^2). Linear acceleration readings are always

OpenEphys.Onix1/ConfigureOutputClock.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public bool ClockGate
5757
/// integer multiple of the <see cref="ContextTask.AcquisitionClockHz">Acquisition Clock</see>
5858
/// frequency. Therefore, the true clock frequency will be set to a value that is as close as possible
5959
/// to the requested setting while respecting this constraint. The value as actualized in hardware is
60-
/// reported by <see cref="OutputClockData"/>.
60+
/// reported by <see cref="OutputClockHardwareParameters"/>.
6161
/// </remarks>
6262
[Range(0.1, 10e6)]
6363
[Category(ConfigurationCategory)]
@@ -79,7 +79,7 @@ public double Frequency
7979
/// multiple of the <see cref="ContextTask.AcquisitionClockHz">Acquisition Clock</see> frequency.
8080
/// Therefore, the true duty cycle will be set to a value that is as close as possible to the
8181
/// requested setting while respecting this constraint. The value as actualized in hardware is
82-
/// reported by <see cref="OutputClockData"/>.
82+
/// reported by <see cref="OutputClockHardwareParameters"/>.
8383
/// </remarks>
8484
[Range(10, 90)]
8585
[Editor(DesignTypes.SliderEditor, typeof(UITypeEditor))]
@@ -110,7 +110,7 @@ public double DutyCycle
110110
/// cref="ContextTask.AcquisitionClockHz">Acquisition Clock</see> frequency. Therefore, the true delay
111111
/// cycle will be set to a value that is as close as possible to the requested setting while
112112
/// respecting this constraint. The value as actualized in hardware is reported by <see
113-
/// cref="OutputClockData"/>.
113+
/// cref="OutputClockHardwareParameters"/>.
114114
/// </para>
115115
/// </remarks>
116116
[Category(ConfigurationCategory)]

OpenEphys.Onix1/OutputClockData.cs renamed to OpenEphys.Onix1/OutputClockHardwareParameters.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@
77
namespace OpenEphys.Onix1
88
{
99
/// <summary>
10-
/// Produces a sequence with a single element containing the output clock's exact hardware parameters for each subscription.
10+
/// Produces a sequence with a single element containing the output clock's exact hardware parameters for
11+
/// each subscription.
1112
/// </summary>
1213
/// <remarks>
1314
/// This data IO operator must be linked to an appropriate configuration, such as a <see
1415
/// cref="ConfigureOutputClock"/>, using a shared <c>DeviceName</c>.
1516
/// </remarks>
1617
[Description("Produces a sequence with a single element containing the output clock's hardware parameters for each subscription.")]
17-
public class OutputClockData : Source<OutputClockParameters>
18+
public class OutputClockHardwareParameters : Source<OutputClockParameters>
1819
{
1920
/// <inheritdoc cref = "SingleDeviceFactory.DeviceName"/>
2021
[TypeConverter(typeof(OutputClock.NameConverter))]
@@ -36,4 +37,9 @@ public override IObservable<OutputClockParameters> Generate()
3637
});
3738
}
3839
}
40+
41+
/// <inheritdoc cref = "OutputClockHardwareParameters"/>v
42+
[Obsolete("This operator is obsolete. Use OutputClockHardwareParameters instead. Will be removed in version 1.0.0.")]
43+
public class OutputClockData : OutputClockHardwareParameters { }
44+
3945
}

0 commit comments

Comments
 (0)