Skip to content

Commit 68e3f07

Browse files
committed
Fix crash when updating ComboBox Parameter Editor view
1 parent 6f56db9 commit 68e3f07

File tree

1 file changed

+17
-15
lines changed

1 file changed

+17
-15
lines changed

Source/Processors/Parameter/ParameterEditor.cpp

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -191,28 +191,30 @@ void ComboBoxParameterEditor::comboBoxChanged(ComboBox* comboBox)
191191
}
192192

193193
void ComboBoxParameterEditor::updateView()
194-
{
195-
if (param->getType() == Parameter::CATEGORICAL_PARAM)
196-
{
197-
CategoricalParameter* p = (CategoricalParameter*)param;
198-
199-
const StringArray& categories = p->getCategories();
200-
valueComboBox->clear(dontSendNotification);
201-
202-
for (int i = 0; i < categories.size(); i++)
203-
{
204-
valueComboBox->addItem(categories[i], i + offset);
205-
}
206-
}
207-
194+
{
208195
if (param == nullptr)
209196
{
210197
for (int i = 0; i < valueComboBox->getNumItems(); i++)
211198
valueComboBox->setItemEnabled(valueComboBox->getItemId(i), false);
212199

213200
return;
214201
}
215-
else {
202+
else
203+
{
204+
205+
if (param->getType() == Parameter::CATEGORICAL_PARAM)
206+
{
207+
CategoricalParameter* p = (CategoricalParameter*)param;
208+
209+
const StringArray& categories = p->getCategories();
210+
valueComboBox->clear(dontSendNotification);
211+
212+
for (int i = 0; i < categories.size(); i++)
213+
{
214+
valueComboBox->addItem(categories[i], i + offset);
215+
}
216+
}
217+
216218
for (int i = 0; i < valueComboBox->getNumItems(); i++)
217219
valueComboBox->setItemEnabled(valueComboBox->getItemId(i), true);
218220
}

0 commit comments

Comments
 (0)