Update SyncStatus handling in Synchronizer

Author: anjaldoshi

Source/Processors/Parameter/ParameterEditor.cpp

@@ -849,24 +849,15 @@ void SyncControlButton::paintButton (Graphics& g, bool isMouseOver, bool isButto
     {
         case SyncStatus::OFF:
         {
-            Colour offColour;
-
-            // If the stream generates timestamps, use a transparent blue colour
-            if (node->synchronizer.streamGeneratesTimestamps (streamKey))
-                offColour = Colour (30, 112, 255).withAlpha (0.4f);
-            else
-                // If the stream does not generate timestamps, use the default fill colour
-                offColour = findColour (ThemeColours::defaultFill);
-
             if (isMouseOver)
             {
                 //LIGHT GREY
-                g.setColour (offColour.contrasting (0.2f));
+                g.setColour (findColour (ThemeColours::defaultFill).contrasting (0.2f));
             }
             else
             {
                 //DARK GREY
-                g.setColour (offColour);
+                g.setColour (findColour (ThemeColours::defaultFill));
             }
             break;
         }
@@ -900,15 +891,21 @@ void SyncControlButton::paintButton (Graphics& g, bool isMouseOver, bool isButto
         }
         case SyncStatus::HARDWARE_SYNCED:
         {
+            Colour hwSyncColour = Colour (30, 112, 255);
+
+            // If the acquisition is not running, use a muted colour
+            if (! CoreServices::getAcquisitionStatus())
+                hwSyncColour = hwSyncColour.withAlpha (0.4f);
+
             if (isMouseOver)
             {
                 // SPECIAL BLUE - slightly contrasting
-                g.setColour (Colour (30, 112, 255).contrasting (0.1f));
+                g.setColour (hwSyncColour.contrasting (0.1f));
             }
             else
             {
                 // SPECIAL BLUE
-                g.setColour (Colour (30, 112, 255));
+                g.setColour (hwSyncColour);
             }
             break;
         }

Source/Processors/Synchronizer/Synchronizer.cpp

@@ -530,12 +530,12 @@ bool Synchronizer::streamGeneratesTimestamps (String streamKey)
 
 SyncStatus Synchronizer::getStatus (String streamKey)
 {
-    if (! streamKey.length() || ! acquisitionIsActive)
-        return SyncStatus::OFF;
-
     if (streamGeneratesTimestamps (streamKey))
         return SyncStatus::HARDWARE_SYNCED;
 
+    if (! streamKey.length() || ! acquisitionIsActive)
+        return SyncStatus::OFF;
+
     if (isStreamSynced (streamKey))
         return SyncStatus::SYNCED;
     else