Skip to content

Commit 057cf1b

Browse files
committed
Merge remote-tracking branch 'upstream/main' into feat/add_new_provider_type
Signed-off-by: Simon Schrottner <[email protected]>
2 parents 0dd03b1 + 3c8ca74 commit 057cf1b

File tree

29 files changed

+230
-187
lines changed

29 files changed

+230
-187
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
1818

1919
- name: Set up JDK 8
20-
uses: actions/setup-java@7a6d8a8234af8eb26422e24e3006232cccaa061b # v4
20+
uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4
2121
with:
2222
java-version: '8'
2323
distribution: 'temurin'

.github/workflows/release-please.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121

2222
- name: Set up JDK 8
2323
if: ${{ steps.release.outputs.releases_created }}
24-
uses: actions/setup-java@7a6d8a8234af8eb26422e24e3006232cccaa061b # v4
24+
uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4
2525
with:
2626
java-version: '8'
2727
distribution: 'temurin'

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
[submodule "providers/flagd/test-harness"]
55
path = providers/flagd/test-harness
66
url = https://github.com/open-feature/test-harness.git
7-
branch = v1.1.1
7+
branch = v2.1.0
88
[submodule "providers/flagd/spec"]
99
path = providers/flagd/spec
1010
url = https://github.com/open-feature/spec.git

pom.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,14 @@
104104
<dependency>
105105
<groupId>net.bytebuddy</groupId>
106106
<artifactId>byte-buddy</artifactId>
107-
<version>1.16.1</version>
107+
<version>1.17.0</version>
108108
<scope>test</scope>
109109
</dependency>
110110

111111
<dependency>
112112
<groupId>net.bytebuddy</groupId>
113113
<artifactId>byte-buddy-agent</artifactId>
114-
<version>1.16.1</version>
114+
<version>1.17.0</version>
115115
<scope>test</scope>
116116
</dependency>
117117
<!-- End mockito workaround-->
@@ -189,21 +189,21 @@
189189
<dependency>
190190
<groupId>io.cucumber</groupId>
191191
<artifactId>cucumber-java</artifactId>
192-
<version>7.20.1</version>
192+
<version>7.21.0</version>
193193
<scope>test</scope>
194194
</dependency>
195195

196196
<dependency>
197197
<groupId>io.cucumber</groupId>
198198
<artifactId>cucumber-junit-platform-engine</artifactId>
199-
<version>7.20.1</version>
199+
<version>7.21.0</version>
200200
<scope>test</scope>
201201
</dependency>
202202

203203
<dependency>
204204
<groupId>io.cucumber</groupId>
205205
<artifactId>cucumber-picocontainer</artifactId>
206-
<version>7.20.1</version>
206+
<version>7.21.0</version>
207207
<scope>test</scope>
208208
</dependency>
209209

providers/flagd/pom.xml

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
<properties>
1616
<!-- exclusion expression for e2e tests -->
1717
<testExclusions>**/e2e/*.java</testExclusions>
18-
<io.grpc.version>1.69.1</io.grpc.version>
18+
<io.grpc.version>1.70.0</io.grpc.version>
1919
<!-- caution - updating this will break compatibility with older protobuf-java versions -->
20-
<protobuf-java.min.version>3.25.5</protobuf-java.min.version>
20+
<protobuf-java.min.version>3.25.6</protobuf-java.min.version>
2121
</properties>
2222

2323
<name>flagd</name>
@@ -84,7 +84,7 @@
8484
<dependency>
8585
<groupId>com.google.code.gson</groupId>
8686
<artifactId>gson</artifactId>
87-
<version>2.11.0</version>
87+
<version>2.12.1</version>
8888
</dependency>
8989

9090
<dependency>
@@ -128,7 +128,7 @@
128128
<dependency>
129129
<groupId>commons-codec</groupId>
130130
<artifactId>commons-codec</artifactId>
131-
<version>1.17.2</version>
131+
<version>1.18.0</version>
132132
</dependency>
133133

134134
<dependency>
@@ -150,14 +150,13 @@
150150
<scope>test</scope>
151151
</dependency>
152152
<dependency>
153-
<groupId>org.testcontainers</groupId>
154-
<artifactId>toxiproxy</artifactId>
155-
<version>1.20.4</version>
153+
<groupId>io.rest-assured</groupId>
154+
<artifactId>rest-assured</artifactId>
155+
<version>5.5.0</version>
156156
<scope>test</scope>
157157
</dependency>
158158
<!-- uncomment for logoutput during test runs -->
159-
160-
<dependency>
159+
<dependency>
161160
<groupId>org.slf4j</groupId>
162161
<artifactId>slf4j-simple</artifactId>
163162
<version>2.0.16</version>
@@ -254,7 +253,7 @@
254253
<configuration>
255254
<protocArtifact>com.google.protobuf:protoc:3.25.5:exe:${os.detected.classifier}</protocArtifact>
256255
<pluginId>grpc-java</pluginId>
257-
<pluginArtifact>io.grpc:protoc-gen-grpc-java:1.68.2:exe:${os.detected.classifier}</pluginArtifact>
256+
<pluginArtifact>io.grpc:protoc-gen-grpc-java:1.69.1:exe:${os.detected.classifier}</pluginArtifact>
258257
<protoSourceRoot>${project.basedir}/schemas/protobuf/</protoSourceRoot>
259258
</configuration>
260259
<executions>

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ EvaluationContext getEnrichedContext() {
210210
private void onProviderEvent(FlagdProviderEvent flagdProviderEvent) {
211211

212212
synchronized (eventsLock) {
213-
log.info("FlagdProviderEvent: {}", flagdProviderEvent);
213+
log.info("FlagdProviderEvent: {}", flagdProviderEvent.getEvent());
214214
eventsLock.syncMetadata = flagdProviderEvent.getSyncMetadata();
215215
if (flagdProviderEvent.getSyncMetadata() != null) {
216216
eventsLock.enrichedContext = contextEnricher.apply(flagdProviderEvent.getSyncMetadata());

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/ChannelMonitor.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,11 @@ public static void monitorChannelState(
4747
log.debug("onConnectionLost is null");
4848
}
4949
}
50-
// Re-register the state monitor to watch for the next state transition.
51-
monitorChannelState(currentState, channel, onConnectionReady, onConnectionLost);
50+
if (currentState != ConnectivityState.SHUTDOWN) {
51+
log.debug("shutting down grpc channel");
52+
// Re-register the state monitor to watch for the next state transition.
53+
monitorChannelState(currentState, channel, onConnectionReady, onConnectionLost);
54+
}
5255
});
5356
}
5457

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/grpc/EventStreamObserver.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ public void onCompleted() {}
6464
* @param value the event stream response containing configuration change data
6565
*/
6666
private void handleConfigurationChangeEvent(EventStreamResponse value) {
67+
log.debug("Received provider change event");
6768
List<String> changedFlags = new ArrayList<>();
6869

6970
Map<String, Value> data = value.getData().getFieldsMap();
@@ -80,7 +81,7 @@ private void handleConfigurationChangeEvent(EventStreamResponse value) {
8081
* Handles provider readiness events by clearing the cache (if enabled) and notifying listeners of readiness.
8182
*/
8283
private void handleProviderReadyEvent() {
83-
log.info("Received provider ready event");
84+
log.debug("Received provider ready event");
8485
onReady.accept(new FlagdProviderEvent(ProviderEvent.PROVIDER_READY));
8586
}
8687
}

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnector.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ void observeEventStream(final BlockingQueue<QueuePayload> writeTo, final AtomicB
118118
metadataException = e;
119119
}
120120

121-
log.info("stream");
122121
while (!shutdown.get()) {
123122
final GrpcResponseModel response = streamReceiver.take();
124123
if (response.isComplete()) {

0 commit comments

Comments
 (0)