fixup: release to 8, and do not testcompile on java8

Signed-off-by: Simon Schrottner <[email protected]>

Author: aepfli

pom.xml

@@ -62,6 +62,7 @@
             --add-opens java.base/java.util=ALL-UNNAMED
             --add-opens java.base/java.lang=ALL-UNNAMED
         </surefireArgLine>
+        <skip.tests>false</skip.tests>
     </properties>
 
     <dependencies>
@@ -97,7 +98,7 @@
         <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-core</artifactId>
-            <version>4.11.0</version>
+            <version>5.2.0</version>
             <scope>test</scope>
         </dependency>
 
@@ -238,8 +239,8 @@
                 <version>3.13.0</version>
 
                 <configuration>
-                    <source>8</source>
-                    <target>8</target>
+                    <!-- this will throw an error if we use wrong apis -->
+                    <release>8</release>
                 </configuration>
             </plugin>
 
@@ -545,6 +546,7 @@
             <id>java8</id>
             <properties>
                 <toolchain.jdk.version>(1.8,9)</toolchain.jdk.version>
+                <skip.tests>true</skip.tests>
             </properties>
 
             <build>
@@ -566,9 +568,26 @@
                         <artifactId>maven-surefire-plugin</artifactId>
                         <version>3.5.2</version>
                         <configuration>
-                            <skipTests>true</skipTests>
+                            <skipTests>${skip.tests}</skipTests>
                         </configuration>
                     </plugin>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-compiler-plugin</artifactId>
+                        <version>3.13.0</version>
+                        <executions>
+                            <execution>
+                                <id>default-testCompile</id>
+                                <phase>test-compile</phase>
+                                <goals>
+                                    <goal>testCompile</goal>
+                                </goals>
+                                <configuration>
+                                    <skip>true</skip>
+                                </configuration>
+                            </execution>
+                        </executions>
+                    </plugin>
                 </plugins>
             </build>
         </profile>