Skip to content

Commit ec55663

Browse files
committed
Merge remote-tracking branch 'upstream/main' into feat/grpc-sync-addition
2 parents 75a2659 + eed1ee0 commit ec55663

File tree

4 files changed

+17
-70
lines changed

4 files changed

+17
-70
lines changed

CONTRIBUTING.md

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,13 @@ We use `pytest` for our unit testing, making use of `parametrized` to inject cas
3030

3131
### Integration tests
3232

33-
These are planned once the SDK has been stabilized and a Flagd provider implemented. At that point, we will utilize the [gherkin integration tests](https://github.com/open-feature/test-harness/blob/main/features/evaluation.feature) to validate against a live, seeded Flagd instance.
33+
The Flagd provider utilizes the [gherkin integration tests](https://github.com/open-feature/test-harness/blob/main/features/evaluation.feature) to validate against a live, seeded Flagd instance.
34+
35+
To run the integration tests you need to have a container runtime, like docker, ranger, etc. installed.
36+
37+
```bash
38+
hatch run test
39+
```
3440

3541
### Type checking
3642

@@ -52,6 +58,13 @@ Navigate to the repository folder
5258
cd python-sdk-contrib
5359
```
5460

61+
Checkout submodules
62+
63+
```bash
64+
git submodule update --init --recursive
65+
```
66+
67+
5568
Add your fork as an origin
5669

5770
```bash
@@ -62,15 +75,16 @@ Ensure your development environment is all set up by building and testing
6275

6376
```bash
6477
cd <package>
65-
hatch run test
78+
hatch build
79+
hatch test
6680
```
6781

6882
To start working on a new feature or bugfix, create a new branch and start working on it.
6983

7084
```bash
7185
git checkout -b feat/NAME_OF_FEATURE
7286
# Make your changes
73-
git commit
87+
git commit -s -m "feat: my feature"
7488
git push fork feat/NAME_OF_FEATURE
7589
```
7690

providers/openfeature-provider-flagd/tests/e2e/file/conftest.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@
33
from openfeature.contrib.provider.flagd.config import ResolverType
44
from tests.e2e.testfilter import TestFilter
55

6-
# from tests.e2e.step.config_steps import *
7-
# from tests.e2e.step.event_steps import *
8-
# from tests.e2e.step.provider_steps import *
9-
106
resolver = ResolverType.FILE
117
feature_list = {
128
"~targetURI",

providers/openfeature-provider-flagd/tests/e2e/test_inprocess.py

Lines changed: 0 additions & 32 deletions
This file was deleted.

providers/openfeature-provider-flagd/tests/e2e/test_inprocess_reconnect.py

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)