build: treat warnings as error in all configurations (#572)

askpt · web-flow · commit 4706fc8f2cb1 · 2026-01-23T10:41:11.000-05:00
Signed-off-by: André Silva &lt;2493377+askpt@users.noreply.github.com&gt;
diff --git a/build/Common.props b/build/Common.props
@@ -5,17 +5,14 @@
     <NuGetAudit>true</NuGetAudit>
     <NuGetAuditMode>all</NuGetAuditMode>
     <NuGetAuditLevel>low</NuGetAuditLevel>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(Configuration)'=='Debug'">
     <DebugType>full</DebugType>
     <DebugSymbols>true</DebugSymbols>
   </PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)'=='Release'">
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
-  </PropertyGroup>
-
   <ItemGroup Condition="'$(OS)' == 'Unix'">
     <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3"
       PrivateAssets="all" />
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.Common/Utils/BeforeHook.cs b/test/OpenFeature.Contrib.Providers.Flagd.E2e.Common/Utils/BeforeHook.cs
@@ -5,6 +5,7 @@
 
 namespace OpenFeature.Contrib.Providers.Flagd.E2e.Common.Utils;
 
+#nullable enable
 public class BeforeHook : Hook
 {
     private readonly EvaluationContext context;
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.Common/Utils/State.cs b/test/OpenFeature.Contrib.Providers.Flagd.E2e.Common/Utils/State.cs
@@ -3,6 +3,7 @@
 
 namespace OpenFeature.Contrib.Providers.Flagd.E2e.Common.Utils;
 
+#nullable enable
 public class State
 {
     public ResolverType? ProviderResolverType { get; set; }

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`
`6`	`6`	`namespace OpenFeature.Contrib.Providers.Flagd.E2e.Common.Utils;`
`7`	`7`
	`8`	`+#nullable enable`
`8`	`9`	`public class BeforeHook : Hook`
`9`	`10`	`{`
`10`	`11`	`private readonly EvaluationContext context;`
Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`
`4`	`4`	`namespace OpenFeature.Contrib.Providers.Flagd.E2e.Common.Utils;`
`5`	`5`
	`6`	`+#nullable enable`
`6`	`7`	`public class State`
`7`	`8`	`{`
`8`	`9`	`public ResolverType? ProviderResolverType { get; set; }`