chore: migrate away from SpecFlow to ReqnRoll for BDD E2E tests (#356)

kylejuliandev · askpt · web-flow · commit 6536c9b814e8 · 2025-04-23T18:06:27.000+01:00
Signed-off-by: Kyle Julian &lt;38759683+kylejuliandev@users.noreply.github.com&gt;
Co-authored-by: André Silva &lt;2493377+askpt@users.noreply.github.com&gt;
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest.csproj b/test/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest.csproj
@@ -24,9 +24,9 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="SpecFlow" Version="3.9.74" />
-    <PackageReference Include="SpecFlow.Tools.MsBuild.Generation" Version="3.9.74" />
-    <PackageReference Include="SpecFlow.xUnit" Version="3.9.74" />
+    <PackageReference Include="Reqnroll" Version="2.4.0" />
+    <PackageReference Include="Reqnroll.Tools.MsBuild.Generation" Version="2.4.0" />
+    <PackageReference Include="Reqnroll.xUnit" Version="2.4.0" />
     <PackageReference Include="Testcontainers" Version="4.4.0" />
   </ItemGroup>
 
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/Steps/EvaluationStepDefinitionsProcess.cs b/test/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/Steps/EvaluationStepDefinitionsProcess.cs
@@ -1,5 +1,5 @@
 using OpenFeature.Contrib.Providers.Flagd.E2e.Test;
-using TechTalk.SpecFlow;
+using Reqnroll;
 
 namespace OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest.Steps
 {
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/Steps/FlagdStepDefinitionsProcess.cs b/test/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/Steps/FlagdStepDefinitionsProcess.cs
@@ -1,5 +1,5 @@
 using OpenFeature.Contrib.Providers.Flagd.E2e.Test;
-using TechTalk.SpecFlow;
+using Reqnroll;
 
 namespace OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest.Steps
 {
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/Steps/TestHooks.cs b/test/OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest/Steps/TestHooks.cs
@@ -1,5 +1,5 @@
 ﻿using System.Threading.Tasks;
-using TechTalk.SpecFlow;
+using Reqnroll;
 
 namespace OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest.Steps
 {
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest.csproj b/test/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest.csproj
@@ -24,9 +24,9 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="SpecFlow" Version="3.9.74" />
-    <PackageReference Include="SpecFlow.Tools.MsBuild.Generation" Version="3.9.74" />
-    <PackageReference Include="SpecFlow.xUnit" Version="3.9.74" />
+    <PackageReference Include="Reqnroll" Version="2.4.0" />
+    <PackageReference Include="Reqnroll.Tools.MsBuild.Generation" Version="2.4.0" />
+    <PackageReference Include="Reqnroll.xUnit" Version="2.4.0" />
     <PackageReference Include="Testcontainers" Version="4.4.0" />
   </ItemGroup>
 
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest/Steps/EvaluationStepDefinitionsRpc.cs b/test/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest/Steps/EvaluationStepDefinitionsRpc.cs
@@ -1,5 +1,5 @@
 using OpenFeature.Contrib.Providers.Flagd.E2e.Test;
-using TechTalk.SpecFlow;
+using Reqnroll;
 
 namespace OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest.Steps
 {
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest/Steps/FlagdStepDefinitionsRpc.cs b/test/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest/Steps/FlagdStepDefinitionsRpc.cs
@@ -1,5 +1,5 @@
 using OpenFeature.Contrib.Providers.Flagd.E2e.Test;
-using TechTalk.SpecFlow;
+using Reqnroll;
 
 namespace OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest.Steps
 {
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest/Steps/TestHooks.cs b/test/OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest/Steps/TestHooks.cs
@@ -1,5 +1,5 @@
 ﻿using System.Threading.Tasks;
-using TechTalk.SpecFlow;
+using Reqnroll;
 
 namespace OpenFeature.Contrib.Providers.Flagd.E2e.RpcTest.Steps
 {
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.Test/OpenFeature.Contrib.Providers.Flagd.E2e.Test.csproj b/test/OpenFeature.Contrib.Providers.Flagd.E2e.Test/OpenFeature.Contrib.Providers.Flagd.E2e.Test.csproj
@@ -5,9 +5,9 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="SpecFlow" Version="3.9.74" />
-    <PackageReference Include="SpecFlow.Tools.MsBuild.Generation" Version="3.9.74" />
-    <PackageReference Include="SpecFlow.xUnit" Version="3.9.74" />
+    <PackageReference Include="Reqnroll" Version="2.4.0" />
+    <PackageReference Include="Reqnroll.Tools.MsBuild.Generation" Version="2.4.0" />
+    <PackageReference Include="Reqnroll.xUnit" Version="2.4.0" />
   </ItemGroup>
 
 </Project>
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.Test/Steps/EvaluationStepDefinitionBase.cs b/test/OpenFeature.Contrib.Providers.Flagd.E2e.Test/Steps/EvaluationStepDefinitionBase.cs
@@ -5,7 +5,7 @@
 using System.Threading.Tasks;
 using OpenFeature.Constant;
 using OpenFeature.Model;
-using TechTalk.SpecFlow;
+using Reqnroll;
 using Xunit;
 
 namespace OpenFeature.Contrib.Providers.Flagd.E2e.Test
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.E2e.Test/Steps/FlagdStepDefinitionBase.cs b/test/OpenFeature.Contrib.Providers.Flagd.E2e.Test/Steps/FlagdStepDefinitionBase.cs
@@ -2,7 +2,7 @@
 using System.Threading.Tasks;
 using OpenFeature.Constant;
 using OpenFeature.Model;
-using TechTalk.SpecFlow;
+using Reqnroll;
 using Xunit;
 
 namespace OpenFeature.Contrib.Providers.Flagd.E2e.Test
diff --git a/test/OpenFeature.Contrib.Providers.Flagd.Test/FlagdProviderTest.cs b/test/OpenFeature.Contrib.Providers.Flagd.Test/FlagdProviderTest.cs
@@ -1,12 +1,6 @@
-using System;
-using System.Collections.Generic;
-using System.Threading;
-using System.Threading.Channels;
-using System.Threading.Tasks;
 using Google.Protobuf.WellKnownTypes;
 using Grpc.Core;
 using NSubstitute;
-using NSubstitute.ExceptionExtensions;
 using NSubstitute.ReceivedExtensions;
 using OpenFeature.Constant;
 using OpenFeature.Contrib.Providers.Flagd.Resolver.InProcess;
@@ -15,6 +9,11 @@
 using OpenFeature.Flagd.Grpc.Evaluation;
 using OpenFeature.Flagd.Grpc.Sync;
 using OpenFeature.Model;
+using System;
+using System.Collections.Generic;
+using System.Threading;
+using System.Threading.Channels;
+using System.Threading.Tasks;
 using Xunit;
 using Metadata = Grpc.Core.Metadata;
 using ProtoValue = Google.Protobuf.WellKnownTypes.Value;
@@ -338,18 +337,15 @@ public async Task TestResolveFlagNotFound()
             var flagdProvider = new FlagdProvider(rpcResolver);
 
             // make sure the correct exception is thrown
-            await Assert.ThrowsAsync<FeatureProviderException>(async () =>
+            var ex = await Assert.ThrowsAsync<FeatureProviderException>(async () =>
             {
-                try
-                {
-                    await flagdProvider.ResolveBooleanValueAsync("my-key", true);
-                }
-                catch (FeatureProviderException e)
-                {
-                    Assert.Equal(ErrorType.FlagNotFound, e.ErrorType);
-                    Assert.Equal(ErrorType.FlagNotFound.ToString(), e.Message);
-                    throw;
-                }
+                await flagdProvider.ResolveBooleanValueAsync("my-key", true);
+            });
+
+            Assert.Multiple(() =>
+            {
+                Assert.Equal(ErrorType.FlagNotFound, ex.ErrorType);
+                Assert.Equal(ErrorType.FlagNotFound.ToString(), ex.Message);
             });
         }
 
@@ -374,18 +370,15 @@ public async Task TestResolveGrpcHostUnavailable()
             var flagdProvider = new FlagdProvider(rpcResolver);
 
             // make sure the correct exception is thrown
-            await Assert.ThrowsAsync<FeatureProviderException>(async () =>
+            var ex = await Assert.ThrowsAsync<FeatureProviderException>(async () =>
             {
-                try
-                {
-                    await flagdProvider.ResolveBooleanValueAsync("my-key", true);
-                }
-                catch (FeatureProviderException e)
-                {
-                    Assert.Equal(ErrorType.ProviderNotReady, e.ErrorType);
-                    Assert.Equal(ErrorType.ProviderNotReady.ToString(), e.Message);
-                    throw;
-                }
+                await flagdProvider.ResolveBooleanValueAsync("my-key", true);
+            });
+
+            Assert.Multiple(() =>
+            {
+                Assert.Equal(ErrorType.ProviderNotReady, ex.ErrorType);
+                Assert.Equal(ErrorType.ProviderNotReady.ToString(), ex.Message);
             });
         }
 
@@ -410,25 +403,22 @@ public async Task TestResolveTypeMismatch()
             var flagdProvider = new FlagdProvider(rpcResolver);
 
             // make sure the correct exception is thrown
-            await Assert.ThrowsAsync<FeatureProviderException>(async () =>
+            var ex = await Assert.ThrowsAsync<FeatureProviderException>(() =>
             {
-                try
-                {
-                    await flagdProvider.ResolveBooleanValueAsync("my-key", true);
-                }
-                catch (FeatureProviderException e)
-                {
-                    Assert.Equal(ErrorType.TypeMismatch, e.ErrorType);
-                    Assert.Equal(ErrorType.TypeMismatch.ToString(), e.Message);
-                    throw;
-                }
+                return flagdProvider.ResolveBooleanValueAsync("my-key", true);
+            });
+
+            Assert.Multiple(() =>
+            {
+                Assert.Equal(ErrorType.TypeMismatch, ex.ErrorType);
+                Assert.Equal(ErrorType.TypeMismatch.ToString(), ex.Message);
             });
         }
 
         [Fact]
         public async Task TestResolveUnknownError()
         {
-            var exc = new RpcException(new Status(StatusCode.Internal, "unknown error"));
+            var exc = new RpcException(new Status(StatusCode.Internal, ErrorType.General.ToString()));
 
             var grpcResp = new AsyncUnaryCall<ResolveBooleanResponse>(
                 Task.FromException<ResolveBooleanResponse>(exc),
@@ -446,18 +436,15 @@ public async Task TestResolveUnknownError()
             var flagdProvider = new FlagdProvider(rpcResolver);
 
             // make sure the correct exception is thrown
-            await Assert.ThrowsAsync<FeatureProviderException>(async () =>
+            var ex = await Assert.ThrowsAsync<FeatureProviderException>(() =>
             {
-                try
-                {
-                    await flagdProvider.ResolveBooleanValueAsync("my-key", true);
-                }
-                catch (FeatureProviderException e)
-                {
-                    Assert.Equal(ErrorType.General, e.ErrorType);
-                    Assert.Equal("unknown error", e.Message);
-                    throw;
-                }
+                return flagdProvider.ResolveBooleanValueAsync("my-key", true);
+            });
+
+            Assert.Multiple(() =>
+            {
+                Assert.Equal(ErrorType.General, ex.ErrorType);
+                Assert.Equal(ErrorType.General.ToString(), ex.Message);
             });
         }
 
@@ -757,7 +744,7 @@ public async Task TestInProcessResolver()
             await Utils.AssertUntilAsync(
                 async _ =>
                 {
-                    var val = await flagdProvider.ResolveBooleanValueAsync("staticBoolFlag", false);
+                    var val = await flagdProvider.ResolveBooleanValueAsync("staticBoolFlag", false, cancellationToken: CancellationToken.None);
                     Assert.True(val.Value);
                 });
 
diff --git a/test/OpenFeature.Contrib.Providers.GOFeatureFlag.Test/GoFeatureFlagProviderTest.cs b/test/OpenFeature.Contrib.Providers.GOFeatureFlag.Test/GoFeatureFlagProviderTest.cs
@@ -1,16 +1,16 @@
+using Newtonsoft.Json.Linq;
+using OpenFeature.Constant;
+using OpenFeature.Contrib.Providers.GOFeatureFlag.exception;
+using OpenFeature.Contrib.Providers.GOFeatureFlag.models;
+using OpenFeature.Model;
+using RichardSzalay.MockHttp;
 using System;
 using System.Collections.Generic;
 using System.Net;
 using System.Net.Http;
 using System.Text;
 using System.Text.Json;
 using System.Threading.Tasks;
-using Newtonsoft.Json.Linq;
-using OpenFeature.Constant;
-using OpenFeature.Contrib.Providers.GOFeatureFlag.exception;
-using OpenFeature.Contrib.Providers.GOFeatureFlag.models;
-using OpenFeature.Model;
-using RichardSzalay.MockHttp;
 using Xunit;
 
 namespace OpenFeature.Contrib.Providers.GOFeatureFlag.Test;
@@ -589,7 +589,7 @@ public async Task should_have_default_exporter_metadata_in_context()
         });
         await Api.Instance.SetProviderAsync(g);
         var client = Api.Instance.GetClient("test-client");
-        var res = client.GetObjectDetailsAsync("integer_key", new Value("default"), _defaultEvaluationCtx);
+        var res = await client.GetObjectDetailsAsync("integer_key", new Value("default"), _defaultEvaluationCtx);
         Assert.Equal(1, mock.GetMatchCount(mockedRequest));
         await Task.Delay(100); // time to wait to be sure body is extracted
         var want = JObject.Parse(
@@ -629,7 +629,7 @@ public async Task should_have_custom_exporter_metadata_in_context()
         });
         await Api.Instance.SetProviderAsync(g);
         var client = Api.Instance.GetClient("test-client");
-        var res = client.GetObjectDetailsAsync("integer_key", new Value("default"), _defaultEvaluationCtx);
+        var res = await client.GetObjectDetailsAsync("integer_key", new Value("default"), _defaultEvaluationCtx);
         Assert.Equal(1, mock.GetMatchCount(mockedRequest));
         await Task.Delay(100); // time to wait to be sure body is extracted
         var want = JObject.Parse(
diff --git a/test/OpenFeature.Contrib.Providers.Statsig.Test/StatsigProviderTest.cs b/test/OpenFeature.Contrib.Providers.Statsig.Test/StatsigProviderTest.cs
@@ -1,9 +1,9 @@
 using AutoFixture.Xunit2;
-using OpenFeature.Constant;
 using OpenFeature.Model;
+using Statsig;
 using System.Threading.Tasks;
 using Xunit;
-using Statsig;
+
 namespace OpenFeature.Contrib.Providers.Statsig.Test;
 
 public class StatsigProviderTest

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`using OpenFeature.Contrib.Providers.Flagd.E2e.Test;`
`2`		`-using TechTalk.SpecFlow;`
	`2`	`+using Reqnroll;`
`3`	`3`
`4`	`4`	`namespace OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest.Steps`
`5`	`5`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`using System.Threading.Tasks;`
`2`		`-using TechTalk.SpecFlow;`
	`2`	`+using Reqnroll;`
`3`	`3`
`4`	`4`	`namespace OpenFeature.Contrib.Providers.Flagd.E2e.ProcessTest.Steps`
`5`	`5`	`{`