fix: some issues in the GO Feature Flag relay proxy (#45)

Signed-off-by: Thomas Poignant <[email protected]>

Author: thomaspoignant

src/OpenFeature.Contrib.Providers.GOFeatureFlag/GoFeatureFlagProvider.cs

@@ -181,7 +181,7 @@ public override async Task<ResolutionDetails<double>> ResolveDoubleValue(string
             try
             {
                 var resp = await CallApi(flagKey, defaultValue, context);
-                return new ResolutionDetails<double>(flagKey, double.Parse(resp.value.ToString()), ErrorType.None,
+                return new ResolutionDetails<double>(flagKey, double.Parse(resp.value.ToString(), System.Globalization.CultureInfo.InvariantCulture), ErrorType.None,
                     resp.reason, resp.variationType);
             }
             catch (FormatException e)
@@ -267,7 +267,7 @@ private async Task<GoFeatureFlagResponse> CallApi<T>(string flagKey, T defaultVa
             if (goffResp != null && Reason.Disabled.Equals(goffResp.reason))
                 throw new FlagDisabled();
 
-            if (ErrorType.FlagNotFound.ToString().Equals(goffResp.errorCode))
+            if ("FLAG_NOT_FOUND".Equals(goffResp.errorCode))
                 throw new FlagNotFoundError($"flag {flagKey} was not found in your configuration");
 
             return goffResp;

test/OpenFeature.Contrib.Providers.GOFeatureFlag.Test/GoFeatureFlagProviderTest.cs

@@ -51,7 +51,8 @@ private static HttpMessageHandler InitMock()
             "{\"trackEvents\":true,\"variationType\":\"True\",\"failed\":false,\"version\":\"\",\"reason\":\"TARGETING_MATCH\",\"errorCode\":\"\",\"value\":\"CC0000\"}");
         mockHttp.When($"{prefixEval}unknown_reason{suffixEval}").Respond(mediaType,
             "{\"trackEvents\":true,\"variationType\":\"True\",\"failed\":false,\"version\":\"\",\"reason\":\"CUSTOM_REASON\",\"errorCode\":\"\",\"value\":true}");
-
+        mockHttp.When($"{prefixEval}does_not_exists{suffixEval}").Respond(mediaType,
+            "{\"trackEvents\":true,\"variationType\":\"defaultSdk\",\"failed\":true,\"version\":\"\",\"reason\":\"ERROR\",\"errorCode\":\"FLAG_NOT_FOUND\",\"value\":\"\"}");
         return mockHttp;
     }
 
@@ -500,4 +501,23 @@ private void should_resolve_a_valid_value_flag_with_a_list()
         Assert.Equal(Reason.TargetingMatch, res.Result.Reason);
         Assert.Equal("True", res.Result.Variant);
     }
+
+    [Fact]
+    private void should_use_object_default_value_if_flag_not_found()
+    {
+        var g = new GoFeatureFlagProvider(new GoFeatureFlagProviderOptions
+        {
+            Endpoint = baseUrl,
+            HttpMessageHandler = _mockHttp,
+            Timeout = new TimeSpan(1000 * TimeSpan.TicksPerMillisecond)
+        });
+        Api.Instance.SetProvider(g);
+        var client = Api.Instance.GetClient("test-client");
+        var res = client.GetObjectDetails("does_not_exists", new Value("default"), _defaultEvaluationCtx);
+        Assert.NotNull(res.Result);
+        Assert.Equal(new Value("default").AsString, res.Result.Value.AsString);
+        Assert.Equal(Reason.Error, res.Result.Reason);
+        Assert.Equal(ErrorType.FlagNotFound, res.Result.ErrorType);
+        Assert.Equal("flag does_not_exists was not found in your configuration", res.Result.ErrorMessage);
+    }
 }