refactor: Clarify tracking context handling and rename test for invalid tracking event name

askpt · askpt · commit 209cd1fb9170 · 2025-10-27T16:13:29.000Z
Signed-off-by: André Silva &lt;2493377+askpt@users.noreply.github.com&gt;
diff --git a/src/OpenFeature.Providers.MultiProvider/MultiProvider.cs b/src/OpenFeature.Providers.MultiProvider/MultiProvider.cs
@@ -133,7 +133,7 @@ public override void Track(string trackingEventName, EvaluationContext? evaluati
                 registeredProvider.Provider,
                 registeredProvider.Name,
                 registeredProvider.Status,
-                string.Empty); // Empty flag key for tracking context
+                string.Empty); // Tracking operations are not flag-specific, so the flag key is intentionally set to an empty string
 
             if (this._evaluationStrategy.ShouldTrackWithThisProvider(providerContext, evaluationContext, trackingEventName, trackingEventDetails))
             {
diff --git a/test/OpenFeature.Providers.MultiProvider.Tests/MultiProviderTrackingTests.cs b/test/OpenFeature.Providers.MultiProvider.Tests/MultiProviderTrackingTests.cs
@@ -275,7 +275,7 @@ public async Task Track_WithComplexTrackingDetails_PropagatesAllDetails()
     [InlineData(null)]
     [InlineData("")]
     [InlineData(" ")]
-    public async Task Track_WhenEmptyTrackingDetails_DoesNotThrow(string? trackingEventName)
+    public async Task Track_WhenInvalidTrackingEventName_DoesNotCallProviders(string? trackingEventName)
     {
         // Arrange
         var providerEntries = new List<ProviderEntry>

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ public override void Track(string trackingEventName, EvaluationContext? evaluati`
`133`	`133`	`registeredProvider.Provider,`
`134`	`134`	`registeredProvider.Name,`
`135`	`135`	`registeredProvider.Status,`
`136`		`- string.Empty); // Empty flag key for tracking context`
	`136`	`+ string.Empty); // Tracking operations are not flag-specific, so the flag key is intentionally set to an empty string`
`137`	`137`
`138`	`138`	`if (this._evaluationStrategy.ShouldTrackWithThisProvider(providerContext, evaluationContext, trackingEventName, trackingEventDetails))`
`139`	`139`	`{`
Original file line number	Diff line number	Diff line change
`@@ -275,7 +275,7 @@ public async Task Track_WithComplexTrackingDetails_PropagatesAllDetails()`
`275`	`275`	`[InlineData(null)]`
`276`	`276`	`[InlineData("")]`
`277`	`277`	`[InlineData(" ")]`
`278`		`- public async Task Track_WhenEmptyTrackingDetails_DoesNotThrow(string? trackingEventName)`
	`278`	`+ public async Task Track_WhenInvalidTrackingEventName_DoesNotCallProviders(string? trackingEventName)`
`279`	`279`	`{`
`280`	`280`	`// Arrange`
`281`	`281`	`var providerEntries = new List<ProviderEntry>`