chore: improve gRPC sync service shutdown behavior (#1375)

Kavindu-Dodan · web-flow · commit 79d9085a50c4 · 2024-08-05T16:18:25.000-04:00
Signed-off-by: Kavindu Dodanduwa &lt;kavindudodanduwa@gmail.com&gt;
diff --git a/flagd/pkg/service/flag-sync/sync_service.go b/flagd/pkg/service/flag-sync/sync_service.go
@@ -119,10 +119,7 @@ func (s *Service) Emit(isResync bool, source string) {
 }
 
 func (s *Service) shutdown() {
-	err := s.listener.Close()
-	if err != nil {
-		s.logger.Warn(fmt.Sprintf("error closing the listener: %v", err))
-	}
+	s.logger.Info("shutting down gRPC sync service")
 	s.server.Stop()
 }
 

Original file line number	Diff line number	Diff line change
`@@ -119,10 +119,7 @@ func (s *Service) Emit(isResync bool, source string) {`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`func (s *Service) shutdown() {`
`122`		`- err := s.listener.Close()`
`123`		`- if err != nil {`
`124`		`- s.logger.Warn(fmt.Sprintf("error closing the listener: %v", err))`
`125`		`- }`
	`122`	`+ s.logger.Info("shutting down gRPC sync service")`
`126`	`123`	`s.server.Stop()`
`127`	`124`	`}`
`128`	`125`