refactor: rename buildOtlpExporter to buildGrpcTraceExporter for clarity

askpt · askpt · commit a4c8929f8d04 · 2025-10-13T21:05:36.000+01:00
Signed-off-by: André Silva &lt;2493377+askpt@users.noreply.github.com&gt;
diff --git a/core/pkg/telemetry/builder.go b/core/pkg/telemetry/builder.go
@@ -86,7 +86,7 @@ func BuildTraceProvider(ctx context.Context, logger *logger.Logger, svc string,
 		return nil
 	}
 
-	exporter, err := buildOtlpExporter(ctx, cfg.CollectorConfig)
+	exporter, err := buildGrpcTraceExporter(ctx, cfg.CollectorConfig)
 	if err != nil {
 		return err
 	}
@@ -238,8 +238,8 @@ func buildMetricReader(ctx context.Context, cfg Config) (metric.Reader, error) {
 	return metric.NewPeriodicReader(otelExporter), nil
 }
 
-// buildOtlpExporter is a helper to build grpc backed otlp trace exporter
-func buildOtlpExporter(ctx context.Context, cfg CollectorConfig) (*otlptrace.Exporter, error) {
+// buildGrpcTraceExporter is a helper to build grpc backed otlp trace exporter
+func buildGrpcTraceExporter(ctx context.Context, cfg CollectorConfig) (*otlptrace.Exporter, error) {
 	transportCredentials, err := buildTransportCredentials(ctx, cfg)
 	if err != nil {
 		return nil, fmt.Errorf("metric export would not build transport credentials: %w", err)

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ func BuildTraceProvider(ctx context.Context, logger *logger.Logger, svc string,`
`86`	`86`	`return nil`
`87`	`87`	`}`
`88`	`88`
`89`		`- exporter, err := buildOtlpExporter(ctx, cfg.CollectorConfig)`
	`89`	`+ exporter, err := buildGrpcTraceExporter(ctx, cfg.CollectorConfig)`
`90`	`90`	`if err != nil {`
`91`	`91`	`return err`
`92`	`92`	`}`
`@@ -238,8 +238,8 @@ func buildMetricReader(ctx context.Context, cfg Config) (metric.Reader, error) {`
`238`	`238`	`return metric.NewPeriodicReader(otelExporter), nil`
`239`	`239`	`}`
`240`	`240`
`241`		`-// buildOtlpExporter is a helper to build grpc backed otlp trace exporter`
`242`		`-func buildOtlpExporter(ctx context.Context, cfg CollectorConfig) (*otlptrace.Exporter, error) {`
	`241`	`+// buildGrpcTraceExporter is a helper to build grpc backed otlp trace exporter`
	`242`	`+func buildGrpcTraceExporter(ctx context.Context, cfg CollectorConfig) (*otlptrace.Exporter, error) {`
`243`	`243`	`transportCredentials, err := buildTransportCredentials(ctx, cfg)`
`244`	`244`	`if err != nil {`
`245`	`245`	`return nil, fmt.Errorf("metric export would not build transport credentials: %w", err)`