Skip to content

Commit a2312a3

Browse files
fix(flagd): provide backoff defaults in unit tests, increase e2e timeout, decrease e2e retrybackoffmax
Signed-off-by: Alexandra Oberaigner <[email protected]>
1 parent 42ee469 commit a2312a3

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ test:
1717

1818
# call with TESTCONTAINERS_RYUK_DISABLED="true" to avoid problems with podman on Macs
1919
e2e:
20-
go clean -testcache && go list -f '{{.Dir}}/...' -m | xargs -I{} go test -timeout=2m -tags=e2e {}
20+
go clean -testcache && go list -f '{{.Dir}}/...' -m | xargs -I{} go test -timeout=3m -tags=e2e {}
2121

2222
lint:
2323
go install -v github.com/golangci/golangci-lint/v2/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION)

providers/flagd/e2e/inprocess_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ func TestInProcessProviderE2E(t *testing.T) {
1919
ResolverType: testframework.InProcess,
2020
TestbedConfig: "default",
2121
ExtraOptions: []flagd.ProviderOption{
22-
flagd.WithRetryBackoffMaxMs(5000),
22+
flagd.WithRetryBackoffMaxMs(4000),
2323
},
2424
})
2525
defer runner.Cleanup()

providers/flagd/pkg/service/in_process/service_grpc_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ func TestInProcessProviderEvaluation(t *testing.T) {
5454
Port: port,
5555
Selector: scope,
5656
TLSEnabled: false,
57+
RetryBackOffMaxMs: 5000,
58+
RetryBackOffMs: 1000,
5759
})
5860

5961
// when
@@ -141,6 +143,8 @@ func TestInProcessProviderEvaluationEnvoy(t *testing.T) {
141143
TargetUri: "envoy://localhost:9211/foo.service",
142144
Selector: scope,
143145
TLSEnabled: false,
146+
RetryBackOffMaxMs: 5000,
147+
RetryBackOffMs: 1000,
144148
})
145149

146150
// when

0 commit comments

Comments
 (0)