Skip to content

Commit a25f7be

Browse files
fix(flagd): provide backoff defaults in unit tests, increase e2e timeout, disable @forbidden test for rpc
Signed-off-by: Alexandra Oberaigner <[email protected]>
1 parent 42ee469 commit a25f7be

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ test:
1717

1818
# call with TESTCONTAINERS_RYUK_DISABLED="true" to avoid problems with podman on Macs
1919
e2e:
20-
go clean -testcache && go list -f '{{.Dir}}/...' -m | xargs -I{} go test -timeout=2m -tags=e2e {}
20+
go clean -testcache && go list -f '{{.Dir}}/...' -m | xargs -I{} go test -timeout=3m -tags=e2e {}
2121

2222
lint:
2323
go install -v github.com/golangci/golangci-lint/v2/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION)

providers/flagd/e2e/rpc_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func TestRPCProviderE2E(t *testing.T) {
2626
}
2727

2828
// Run tests with RPC-specific tags - exclude unimplemented scenarios
29-
tags := "@rpc && ~@unixsocket && ~@targetURI && ~@sync && ~@metadata && ~@grace && ~@customCert && ~@caching"
29+
tags := "@rpc && ~@unixsocket && ~@targetURI && ~@sync && ~@metadata && ~@grace && ~@customCert && ~@caching && ~@forbidden"
3030

3131
if err := runner.RunGherkinTestsWithSubtests(t, featurePaths, tags); err != nil {
3232
t.Fatalf("Gherkin tests failed: %v", err)

providers/flagd/pkg/service/in_process/service_grpc_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ func TestInProcessProviderEvaluation(t *testing.T) {
5454
Port: port,
5555
Selector: scope,
5656
TLSEnabled: false,
57+
RetryBackOffMaxMs: 5000,
58+
RetryBackOffMs: 1000,
5759
})
5860

5961
// when
@@ -141,6 +143,8 @@ func TestInProcessProviderEvaluationEnvoy(t *testing.T) {
141143
TargetUri: "envoy://localhost:9211/foo.service",
142144
Selector: scope,
143145
TLSEnabled: false,
146+
RetryBackOffMaxMs: 5000,
147+
RetryBackOffMs: 1000,
144148
})
145149

146150
// when

0 commit comments

Comments
 (0)