@@ -24,7 +24,7 @@ type Comparator func(values []any) bool
2424// can be passed as long as ObjectEvaluation is never called with objects that are not comparable. The custom [Comparator]
2525// will only be used for [of.FeatureProvider.ObjectEvaluation] if set. If [of.FeatureProvider.ObjectEvaluation] is
2626// called without setting a [Comparator], and the returned object(s) are not comparable, then an error will occur.
27- func newComparisonStrategy (providers []* NamedProvider , fallbackProvider of.FeatureProvider , comparator Comparator ) StrategyFn [FlagTypes ] {
27+ func newComparisonStrategy (providers []NamedProvider , fallbackProvider of.FeatureProvider , comparator Comparator ) StrategyFn [FlagTypes ] {
2828 return evaluateComparison [FlagTypes ](providers , fallbackProvider , comparator )
2929}
3030
@@ -81,7 +81,7 @@ func comparisonResolutionError(metadata of.FlagMetadata) of.ResolutionError {
8181 return of .NewGeneralResolutionError ("comparison failure" )
8282}
8383
84- func evaluateComparison [T FlagTypes ](providers []* NamedProvider , fallbackProvider of.FeatureProvider , comparator Comparator ) StrategyFn [T ] {
84+ func evaluateComparison [T FlagTypes ](providers []NamedProvider , fallbackProvider of.FeatureProvider , comparator Comparator ) StrategyFn [T ] {
8585 return func (ctx context.Context , flag string , defaultValue T , evalCtx of.FlattenedContext ) of.GenericResolutionDetail [T ] {
8686 if comparator == nil {
8787 comparator = defaultComparator
@@ -103,7 +103,7 @@ func evaluateComparison[T FlagTypes](providers []*NamedProvider, fallbackProvide
103103 // Short circuit if there's only one provider as no comparison nor workers are needed
104104 if len (providers ) == 1 {
105105 result := Evaluate (ctx , providers [0 ], flag , defaultValue , evalCtx )
106- metadata := setFlagMetadata (StrategyComparison , providers [0 ].Name , make (of.FlagMetadata ))
106+ metadata := setFlagMetadata (StrategyComparison , providers [0 ].Name () , make (of.FlagMetadata ))
107107 metadata [MetadataFallbackUsed ] = false
108108 result .FlagMetadata = mergeFlagMeta (result .FlagMetadata , metadata )
109109 return result
@@ -124,13 +124,13 @@ func evaluateComparison[T FlagTypes](providers []*NamedProvider, fallbackProvide
124124 notFound := result .ResolutionDetail ().ErrorCode == of .FlagNotFoundCode
125125 if ! notFound && result .Error () != nil {
126126 return & ProviderError {
127- ProviderName : closedProvider .Name ,
128- Err : result .Error (),
127+ ProviderName : closedProvider .Name () ,
128+ err : result .Error (),
129129 }
130130 }
131131 if ! notFound {
132132 resultChan <- & namedResult {
133- name : closedProvider .Name ,
133+ name : closedProvider .Name () ,
134134 res : & result ,
135135 }
136136 } else {
@@ -225,7 +225,7 @@ func evaluateComparison[T FlagTypes](providers []*NamedProvider, fallbackProvide
225225 if fallbackProvider != nil {
226226 fallbackResult := Evaluate (
227227 ctx ,
228- & NamedProvider { Name : "fallback" , FeatureProvider : fallbackProvider },
228+ & namedProvider { name : "fallback" , FeatureProvider : fallbackProvider },
229229 flag ,
230230 defaultValue ,
231231 evalCtx ,
0 commit comments